Update final copy

duckduckgo · Nov 9, 2024 · fcca964 · fcca964
1 parent 5c440ce
commit fcca964
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 28 deletions.
diff --git a/app/src/main/java/com/duckduckgo/app/cta/ui/Cta.kt b/app/src/main/java/com/duckduckgo/app/cta/ui/Cta.kt
@@ -38,7 +38,6 @@ import com.duckduckgo.app.global.install.AppInstallStore
 import com.duckduckgo.app.global.install.daysInstalled
 import com.duckduckgo.app.onboarding.store.OnboardingStore
 import com.duckduckgo.app.onboarding.store.OnboardingStoreImpl.ContentType.DESCRIPTION
-import com.duckduckgo.app.onboarding.store.OnboardingStoreImpl.ContentType.PRIMARY_BUTTON
 import com.duckduckgo.app.onboarding.store.OnboardingStoreImpl.ContentType.TITLE
 import com.duckduckgo.app.pixels.AppPixelName
 import com.duckduckgo.app.settings.db.SettingsDataStore
@@ -976,7 +975,7 @@ sealed class DaxBubbleCta(
         title = onboardingStore.getPrivacyProContent(TITLE),
         description = onboardingStore.getPrivacyProContent(DESCRIPTION),
         placeholder = com.duckduckgo.mobile.android.R.drawable.ic_privacy_pro_128,
-        primaryCta = onboardingStore.getPrivacyProContent(PRIMARY_BUTTON),
+        primaryCta = R.string.onboardingPrivacyProDaxDialogOkButton,
         secondaryCta = R.string.onboardingPrivacyProDaxDialogCancelButton,
         shownPixel = AppPixelName.ONBOARDING_DAX_CTA_SHOWN,
         okPixel = AppPixelName.ONBOARDING_DAX_CTA_OK_BUTTON,
@@ -1041,7 +1040,7 @@ sealed class DaxBubbleCta(
         title = onboardingStore.getPrivacyProContent(TITLE),
         description = onboardingStore.getPrivacyProContent(DESCRIPTION),
         placeholder = com.duckduckgo.mobile.android.R.drawable.ic_privacy_pro_128,
-        primaryCta = onboardingStore.getPrivacyProContent(PRIMARY_BUTTON),
+        primaryCta = R.string.onboardingPrivacyProDaxDialogOkButton,
         secondaryCta = R.string.onboardingPrivacyProDaxDialogCancelButton,
         shownPixel = AppPixelName.ONBOARDING_DAX_CTA_SHOWN,
         okPixel = AppPixelName.ONBOARDING_DAX_CTA_OK_BUTTON,

diff --git a/app/src/main/java/com/duckduckgo/app/onboarding/store/OnboardingStoreImpl.kt b/app/src/main/java/com/duckduckgo/app/onboarding/store/OnboardingStoreImpl.kt
@@ -22,7 +22,6 @@ import androidx.core.content.edit
 import com.duckduckgo.app.browser.R
 import com.duckduckgo.app.cta.ui.DaxBubbleCta.DaxDialogIntroOption
 import com.duckduckgo.app.onboarding.store.OnboardingStoreImpl.ContentType.DESCRIPTION
-import com.duckduckgo.app.onboarding.store.OnboardingStoreImpl.ContentType.PRIMARY_BUTTON
 import com.duckduckgo.app.onboarding.store.OnboardingStoreImpl.ContentType.TITLE
 import com.duckduckgo.app.onboarding.ui.page.extendedonboarding.ExtendedOnboardingFeatureToggles
 import com.duckduckgo.app.onboarding.ui.page.extendedonboarding.ExtendedOnboardingFeatureToggles.Cohorts
@@ -237,24 +236,12 @@ class OnboardingStoreImpl @Inject constructor(
                     else -> R.string.onboardingPrivacyProDaxDialogDescription
                 }
             }
-            PRIMARY_BUTTON -> {
-                when {
-                    extendedOnboardingFeatureToggles.testPrivacyProOnboardingCopyNov24().isEnabled(Cohorts.PROTECTION) ->
-                        R.string.onboardingPrivacyProProtectionDaxDialogOkButton
-                    extendedOnboardingFeatureToggles.testPrivacyProOnboardingCopyNov24().isEnabled(Cohorts.PIR) ->
-                        R.string.onboardingPrivacyProPirDaxDialogOkButton
-                    extendedOnboardingFeatureToggles.testPrivacyProOnboardingCopyNov24().isEnabled(Cohorts.VPN) ->
-                        R.string.onboardingPrivacyProVpnDaxDialogOkButton
-                    else -> R.string.onboardingPrivacyProDaxDialogOkButton
-                }
-            }
         }
     }
 
     enum class ContentType {
         TITLE,
         DESCRIPTION,
-        PRIMARY_BUTTON,
     }
 
     companion object {

diff --git a/app/src/main/res/values/donottranslate.xml b/app/src/main/res/values/donottranslate.xml
@@ -64,17 +64,11 @@
     <string name="newTabPageIndonesiaMessageCta">Okay</string>
 
     <!-- Privacy Pro onboarding copy test -->
-    <string name="onboardingPrivacyProProtectionDaxDialogTitle">Protection…</string>
-    <string name="onboardingPrivacyProProtectionDaxDialogDescription"><![CDATA[DuckDuckGo Protection also has a built-in <b>VPN</b>!<br/><br/>Activate it with a <b>paid Privacy Pro subscription.</b>]]></string>
-    <string name="onboardingPrivacyProProtectionDaxDialogOkButton">Get More</string>
-    <string name="onboardingPrivacyProProtectionDaxDialogCancelButton">Skip</string>
-    <string name="onboardingPrivacyProPirDaxDialogTitle">PIR…</string>
-    <string name="onboardingPrivacyProPirDaxDialogDescription"><![CDATA[DuckDuckGo PIR also has a built-in <b>VPN</b>!<br/><br/>Activate it with a <b>paid Privacy Pro subscription.</b>]]></string>
-    <string name="onboardingPrivacyProPirDaxDialogOkButton">PIR More</string>
-    <string name="onboardingPrivacyProPirDaxDialogCancelButton">Skip</string>
-    <string name="onboardingPrivacyProVpnDaxDialogTitle">VPN…</string>
-    <string name="onboardingPrivacyProVpnDaxDialogDescription"><![CDATA[DuckDuckGo VPN also has a built-in <b>VPN</b>!<br/><br/>Activate it with a <b>paid Privacy Pro subscription.</b>]]></string>
-    <string name="onboardingPrivacyProVpnDaxDialogOkButton">VPN More</string>
-    <string name="onboardingPrivacyProVpnDaxDialogCancelButton">Skip</string>
+    <string name="onboardingPrivacyProProtectionDaxDialogTitle">Oh, just one more step…</string>
+    <string name="onboardingPrivacyProProtectionDaxDialogDescription"><![CDATA[DuckDuckGo also has a built-in <b>VPN</b>!<br/><br/>Activate it with a <b>paid Privacy Pro subscription</b>.]]></string>
+    <string name="onboardingPrivacyProPirDaxDialogTitle">Ready for a deal…?</string>
+    <string name="onboardingPrivacyProPirDaxDialogDescription"><![CDATA[Get 3 premium protections for the price of 1, including our <b>VPN</b>.<br/><br/>Activate it with a <b>paid Privacy Pro subscription.</b>]]></string>
+    <string name="onboardingPrivacyProVpnDaxDialogTitle">Get even more protection…</string>
+    <string name="onboardingPrivacyProVpnDaxDialogDescription"><![CDATA[You can mask your device (IP address) from sites with our built-in <b>VPN</b>!<br/><br/>Activate it with a <b>paid Privacy Pro subscription</b>.]]></string>
 
 </resources>