Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix text glitches to new line in TypeAnimationTextView #4874

Conversation

bemusementpark
Copy link
Contributor

@bemusementpark bemusementpark commented Aug 7, 2024

Task: https://app.asana.com/0/1125189844152671/1208000645162922/f

Issue URL: #4869

Description

There is a typing animation that adds each letter to the screen sequentially. The last word of each line can jerk to the next line if the word is long enough. On iOS the equivalent animation keeps characters in position as they are revealed. On Android this animation is more akin to what you would see when you are actually typing and you type a long word at the end of a line. The word jerks to the next line. This is fine when you are typing. But at speed an in an animation it does not look good. This PR copies iOS style, and applies 100% transparency to all letters that have not yet been "typed" in the animation.

Steps to test this PR

  1. Install a fresh copy of the app
  2. Do onboarding

Feature 1

  • [ Change TypeAnimationTextView to progressively reveal each character rather than progressively adding each character to the output sting ]

UI changes

Before

Screen_recording_20240807_211447.webm

After

Screen_recording_20240808_021820.webm

Copy link
Contributor

@marcosholgado marcosholgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. There's a bug with the new changes, upon tapping on the TextView the full animation should finish and show the full text. Trying to that now it just stops the animation at the point where it is and the full text is never shown.

See video below:

demo.mp4

@bemusementpark
Copy link
Contributor Author

PTAL @marcosholgado

@bemusementpark
Copy link
Contributor Author

Changes are in (:

@marcosholgado marcosholgado self-assigned this Sep 18, 2024
Copy link
Contributor

@marcosholgado marcosholgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bemusementpark, LGTM

@marcosholgado marcosholgado merged commit 4f73a17 into duckduckgo:develop Sep 18, 2024
1 check failed
@bemusementpark bemusementpark deleted the bug/andy/fix-TypeAnimationTextView-glitch branch September 18, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants