Fix onboarding background - Canvas: trying to draw too large bitmap

app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt

@@ -3883,12 +3883,6 @@ class BrowserTabFragment :
             }
             newBrowserTab.newTabLayout.setOnClickListener { daxDialogIntroBubbleCta.dialogTextCta.finishAnimation() }
 
-            if (appTheme.isLightModeEnabled()) {
-                newBrowserTab.browserBackground.setBackgroundResource(R.drawable.onboarding_experiment_background_bitmap_light)
-            } else {
-                newBrowserTab.browserBackground.setBackgroundResource(R.drawable.onboarding_experiment_background_bitmap_dark)
-            }
-
             viewModel.onCtaShown()
         }
 
@@ -3909,13 +3903,6 @@ class BrowserTabFragment :
                     viewModel.onUserClickCtaOkButton(configuration)
                 }
             }
-            if (appTheme.isLightModeEnabled()) {
-                binding.includeOnboardingDaxDialog.onboardingDaxDialogBackground
-                    .setBackgroundResource(R.drawable.onboarding_experiment_background_bitmap_light)
-            } else {
-                binding.includeOnboardingDaxDialog.onboardingDaxDialogBackground
-                    .setBackgroundResource(R.drawable.onboarding_experiment_background_bitmap_dark)
-            }
             binding.webViewContainer.setOnClickListener { daxDialogIntroBubbleCta.dialogTextCta.finishAnimation() }
             viewModel.onCtaShown()
         }

app/src/main/java/com/duckduckgo/app/onboarding/ui/page/WelcomePage.kt

@@ -54,11 +54,11 @@ import com.duckduckgo.common.ui.viewbinding.viewBinding
 import com.duckduckgo.common.utils.FragmentViewModelFactory
 import com.duckduckgo.common.utils.extensions.html
 import com.duckduckgo.di.scopes.FragmentScope
-import javax.inject.Inject
 import kotlinx.coroutines.flow.launchIn
 import kotlinx.coroutines.flow.onEach
 import nl.dionsegijn.konfetti.models.Shape
 import nl.dionsegijn.konfetti.models.Size
+import javax.inject.Inject
 
 @InjectWith(FragmentScope::class)
 class WelcomePage : OnboardingPageFragment(R.layout.content_onboarding_welcome_page) {
@@ -98,11 +98,7 @@ class WelcomePage : OnboardingPageFragment(R.layout.content_onboarding_welcome_p
         savedInstanceState: Bundle?,
     ): View {
         val binding = ContentOnboardingWelcomePageBinding.inflate(inflater, container, false)
-        if (appTheme.isLightModeEnabled()) {
-            binding.sceneBg.setBackgroundResource(R.drawable.onboarding_experiment_background_bitmap_light)
-        } else {
-            binding.sceneBg.setBackgroundResource(R.drawable.onboarding_experiment_background_bitmap_dark)
-        }
+
         viewModel.commands.flowWithLifecycle(lifecycle, Lifecycle.State.STARTED).onEach {
             when (it) {
                 is ShowComparisonChart -> configureDaxCta(COMPARISON_CHART)

app/src/main/res/layout-land/content_onboarding_welcome_page.xml

@@ -31,7 +31,8 @@
         app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintTop_toTopOf="parent"
-        tools:srcCompat="@drawable/onboarding_experiment_background_light" />
+        app:layout_constraintBottom_toBottomOf="parent"
+        app:srcCompat="@drawable/onboarding_experiment_background" />
 
     <LinearLayout
         android:id="@+id/welcomeContent"

app/src/main/res/layout/content_onboarding_welcome_page.xml

@@ -23,15 +23,16 @@
     android:tag="onboardingDefaultBrowser"
     tools:context="com.duckduckgo.app.onboarding.ui.OnboardingActivity">
 
-    <androidx.appcompat.widget.AppCompatImageView
+    <ImageView
         android:id="@+id/sceneBg"
         android:layout_width="match_parent"
         android:layout_height="match_parent"
         android:scaleType="centerCrop"
         app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintTop_toTopOf="parent"
-        tools:srcCompat="@drawable/onboarding_experiment_background_small_light" />
+        app:layout_constraintBottom_toBottomOf="parent"
+        app:srcCompat="@drawable/onboarding_experiment_background" />
 
     <ImageView
         android:id="@+id/foregroundImageView"

app/src/main/res/layout/include_new_browser_tab.xml

@@ -32,6 +32,16 @@
         android:paddingTop="?attr/actionBarSize"
         android:foreground="@android:color/transparent">
 
+        <ImageView
+            android:layout_width="0dp"
+            android:layout_height="0dp"
+            app:layout_constraintTop_toTopOf="parent"
+            app:layout_constraintBottom_toBottomOf="parent"
+            app:layout_constraintStart_toStartOf="parent"
+            app:layout_constraintEnd_toEndOf="parent"
+            android:scaleType="centerCrop"
+            app:srcCompat="@drawable/onboarding_experiment_background" />
+
         <FrameLayout
             android:id="@+id/newTabContainerLayout"
             android:layout_width="match_parent"

app/src/main/res/layout/include_onboarding_view_dax_dialog.xml

@@ -28,9 +28,18 @@
         android:id="@+id/onboardingDaxDialogBackground"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
-        tools:background="@drawable/onboarding_experiment_background_bitmap_light"
         android:clipChildren="false">
 
+        <ImageView
+            android:layout_width="0dp"
+            android:layout_height="0dp"
+            app:layout_constraintTop_toTopOf="parent"
+            app:layout_constraintBottom_toBottomOf="parent"
+            app:layout_constraintStart_toStartOf="parent"
+            app:layout_constraintEnd_toEndOf="parent"
+            android:scaleType="centerCrop"
+            app:srcCompat="@drawable/onboarding_experiment_background" />
+
         <androidx.appcompat.widget.AppCompatImageView
             android:id="@+id/logo"
             android:layout_width="56dp"