Implementation: [Android] Show a special notice to users in Indonesia #4933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
anikiki
changed the title
anikiki
force-pushed
the
feature/ana/implementation_android_show_a_special_notice_to_users_in_indonesia
branch
from
5688150
to
2d95d94
Compare
malmstein
approved these changes
Sep 3, 2024
...src/main/java/com/duckduckgo/app/browser/indonesiamessage/IndonesiaNewTabSectionDataStore.kt
Show resolved
Hide resolved
| @ContributesActivePlugin( | ||
| AppScope::class, | ||
| boundType = NewTabPageSectionPlugin::class, | ||
| priority = -1, |
There was a problem hiding this comment.
this should be moved to NewTabPageSectionPlugin.PRIORITY_INDONESIA_MESSAGE with a value of 5.
…age plugin priority.
anikiki
force-pushed
the
feature/ana/implementation_android_show_a_special_notice_to_users_in_indonesia
branch
from
2d95d94
to
f46b492
Compare
anikiki
deleted the
feature/ana/implementation_android_show_a_special_notice_to_users_in_indonesia
branch
0nko
pushed a commit
that referenced
this pull request
Sep 9, 2024
…#4933) Task/Issue URL: https://app.asana.com/0/1200581511062568/1208125695673129/f ### Description Added a new section in the New Tab Page and a view in the Legacy Tab Page. ### Steps to test this PR See https://app.asana.com/0/0/1208180779804579/f ### UI changes See https://app.asana.com/0/1200581511062568/1208180779804556/f
0nko
pushed a commit
that referenced
this pull request
Sep 9, 2024
…#4933) Task/Issue URL: https://app.asana.com/0/1200581511062568/1208125695673129/f ### Description Added a new section in the New Tab Page and a view in the Legacy Tab Page. ### Steps to test this PR See https://app.asana.com/0/0/1208180779804579/f ### UI changes See https://app.asana.com/0/1200581511062568/1208180779804556/f
0nko
pushed a commit
that referenced
this pull request
Sep 12, 2024
…#4933) Task/Issue URL: https://app.asana.com/0/1200581511062568/1208125695673129/f ### Description Added a new section in the New Tab Page and a view in the Legacy Tab Page. ### Steps to test this PR See https://app.asana.com/0/0/1208180779804579/f ### UI changes See https://app.asana.com/0/1200581511062568/1208180779804556/f
0nko
pushed a commit
that referenced
this pull request
Sep 17, 2024
…#4933) Task/Issue URL: https://app.asana.com/0/1200581511062568/1208125695673129/f ### Description Added a new section in the New Tab Page and a view in the Legacy Tab Page. ### Steps to test this PR See https://app.asana.com/0/0/1208180779804579/f ### UI changes See https://app.asana.com/0/1200581511062568/1208180779804556/f
0nko
pushed a commit
that referenced
this pull request
Sep 19, 2024
…#4933) Task/Issue URL: https://app.asana.com/0/1200581511062568/1208125695673129/f ### Description Added a new section in the New Tab Page and a view in the Legacy Tab Page. ### Steps to test this PR See https://app.asana.com/0/0/1208180779804579/f ### UI changes See https://app.asana.com/0/1200581511062568/1208180779804556/f
0nko
pushed a commit
that referenced
this pull request
Sep 19, 2024
…#4933) Task/Issue URL: https://app.asana.com/0/1200581511062568/1208125695673129/f ### Description Added a new section in the New Tab Page and a view in the Legacy Tab Page. ### Steps to test this PR See https://app.asana.com/0/0/1208180779804579/f ### UI changes See https://app.asana.com/0/1200581511062568/1208180779804556/f
0nko
pushed a commit
that referenced
this pull request
Sep 23, 2024
…#4933) Task/Issue URL: https://app.asana.com/0/1200581511062568/1208125695673129/f ### Description Added a new section in the New Tab Page and a view in the Legacy Tab Page. ### Steps to test this PR See https://app.asana.com/0/0/1208180779804579/f ### UI changes See https://app.asana.com/0/1200581511062568/1208180779804556/f
0nko
pushed a commit
that referenced
this pull request
Sep 23, 2024
…#4933) Task/Issue URL: https://app.asana.com/0/1200581511062568/1208125695673129/f ### Description Added a new section in the New Tab Page and a view in the Legacy Tab Page. ### Steps to test this PR See https://app.asana.com/0/0/1208180779804579/f ### UI changes See https://app.asana.com/0/1200581511062568/1208180779804556/f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1200581511062568/1208125695673129/f
Description
Added a new section in the New Tab Page and a view in the Legacy Tab Page.
Steps to test this PR
See https://app.asana.com/0/0/1208180779804579/f
UI changes
See https://app.asana.com/0/1200581511062568/1208180779804556/f