Edit temporary pixel for not showing trackers network dialog #5244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
nalcalag
force-pushed
the
feature/noelia/skip_onboarding_dax_player_pixel
branch
2 times, most recently
from
c00ba63
to
1c95804
Compare
CrisBarreiro
approved these changes
Nov 14, 2024
nalcalag
force-pushed
the
feature/noelia/skip_onboarding_dax_player_pixel
branch
from
9598f4f
to
0616a22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/488551667048375/1208660560293084/f
Description
Fire skip network pixel only if onboarding is still active
Steps to test this PR
Send pixel
m_onboarding_skip_major_network_uniqueis sentIgnore pixel
m_onboarding_skip_major_network_uniqueis ignoredPixel not fired
m_onboarding_skip_major_network_uniqueis ** not sent or ignored**No UI changes