Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mac promo exp2 - add support for share link message #375

Merged
merged 6 commits into from
Jun 15, 2023
Merged

mac promo exp2 - add support for share link message #375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e4605a1
support share action
brindy May 26, 2023
602d8b6
Merge branch 'main' into brindy/mac-promo-exp2
brindy May 26, 2023
eb22941
use additional values to set url and title
brindy May 30, 2023
fadce55
remove temp tests
brindy May 31, 2023
36526b6
Merge branch 'main' into brindy/mac-promo-exp2
brindy Jun 13, 2023
78e79eb
Merge branch 'main' into brindy/mac-promo-exp2
brindy Jun 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Sources/BrowserServicesKit/RemoteMessaging/Mappers/JsonToRemoteMessageModelMapper.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,8 @@ struct JsonToRemoteMessageModelMapper {
}

switch RemoteMessageResponse.JsonActionType(rawValue: jsonAction.type) {
case .share:
return .share(url: jsonAction.value, title: jsonAction.additionalValues?[0] ?? "")
case .url:
return .url(value: jsonAction.value)
case .appStore:
Expand Down
2 changes: 2 additions & 0 deletions Sources/BrowserServicesKit/RemoteMessaging/Model/JsonRemoteMessagingConfig.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ public enum RemoteMessageResponse {
struct JsonMessageAction: Decodable {
let type: String
let value: String
let additionalValues: [String]?
}

struct JsonContentTranslation: Decodable {
Expand All @@ -74,6 +75,7 @@ public enum RemoteMessageResponse {
}

enum JsonActionType: String, CaseIterable {
case share
case url
case appStore = "appstore"
case dismiss
Expand Down
1 change: 1 addition & 0 deletions Sources/BrowserServicesKit/RemoteMessaging/Model/RemoteMessageModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ public enum RemoteMessageModelType: Codable, Equatable {
}

public enum RemoteAction: Codable, Equatable {
case share(url: String, title: String)
case url(value: String)
case appStore
case dismiss
Expand Down