Fix NetP iOS incompatibility #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
graeme
commented
Jul 17, 2023
| @@ -21,18 +21,6 @@ import Common | |||
|
|
|||
| #if os(macOS) | |||
|
|
|||
| fileprivate extension Bundle { | |||
There was a problem hiding this comment.
This is called from iOS so, for now, needs to be outside of the macOS compiler-flagged code
diegoreymendez
approved these changes
Jul 17, 2023
graeme
added a commit
to duckduckgo/iOS
that referenced
this pull request
Jul 17, 2023
Task/Issue URL: https://app.asana.com/0/0/1205043071738197/f BSK PR: duckduckgo/BrowserServicesKit#418 Description: Adds the initial classes needed for the PacketTunnelProvider extension and for controlling it from the iOS app along with some configuration. This PR also brings in the NetP iOS compatibility changes needed after some incompatibility was merged. Note that until we’re ready to release, the extension will remain not embedded in the app and any Network Extension code will be compiler flagged
samsymons
added a commit
that referenced
this pull request
Jul 20, 2023
* main: Fix publisher, add option to override internal user state in debug (#422) Removes unused code and makes some other code platform specific (#419) Optimize first load of Content Rule Lists (#406) Automatically add the PR link to the Asana task (#311) NetP: Move bundle prefix to x-platform code (#418)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/0/1205043071738197/f
iOS PR: duckduckgo/iOS#1835
macOS PR: duckduckgo/macos-browser#1356
What kind of version bump will this require?: Minor
Optional:
Tech Design URL:
CC:
Description:
Sadly, on trying to open the linked iOS PR (which wasn’t supposed to need BSK changes), I hit a snag as some iOS incompatible changes made there way into BSK and didn’t get caught by CI (it wasn’t actually being used yet on iOS for the sake of keeping PRs manageable, so it didn’t get caught in the app either). So when I went to create my final PR, it wasn't compiling.
Steps to test this PR:
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template