replace assertion in assertObjectDeallocated with sigint #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mallexxx
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Jul 21, 2023
Task/Issue URL: https://app.asana.com/0/1199230911884351/1205078062142519/f BSK PR: duckduckgo/BrowserServicesKit#428 **Description**: replace deinit check assert with sigint **Steps to test this PR**: 1. Make a retain cycle for Tab or WebView, close the tab 2. Ensure sigint is raised instead of assertion
samsymons
added a commit
that referenced
this pull request
Jul 21, 2023
* main: replace assertion in assertObjectDeallocated with sigint (#428)
tomasstrba
pushed a commit
that referenced
this pull request
Jul 26, 2023
* replace assertion in assertObjectDeallocated with sigint * add different options to ensureObjectDeallocated; fix some warnings
afterxleep
pushed a commit
that referenced
this pull request
Aug 2, 2023
* replace assertion in assertObjectDeallocated with sigint * add different options to ensureObjectDeallocated; fix some warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/1199230911884351/1205078062142519/f
iOS PR: not affected
macOS PR: duckduckgo/macos-browser#1374
What kind of version bump will this require?: Patch
Description:
replace deinit check assert with sigint; UPD: added different options
fix some warning
Steps to test this PR: