Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable trailing_comma #434

Merged
merged 1 commit into from
Jul 26, 2023
Merged

disable trailing_comma #434

merged 1 commit into from
Jul 26, 2023

Conversation

mallexxx
Copy link
Collaborator

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL:
What kind of version bump will this require?: -

Description:

  • disable trailing_comma rule

Steps to test this PR:

  1. validate swiftlint lint doesn‘t raise config validation issues

@mallexxx mallexxx requested a review from Bunn July 26, 2023 06:38
Bunn
Bunn approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@Bunn Bunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mallexxx mallexxx merged commit 51c9619 into main Jul 26, 2023
4 checks passed
@mallexxx mallexxx deleted the alex/disable-trailing_comma branch July 26, 2023 10:48
samsymons added a commit that referenced this pull request Jul 27, 2023
@samsymons
Merge branch 'main' into sam/secure-storage
e390500 
* main:
  Fire Window (#420)
  disable trailing_comma (#434)
  Add support for per-model Sync Data Providers initialization (#433)
afterxleep pushed a commit that referenced this pull request Aug 2, 2023
@mallexxx @afterxleep
disable trailing_comma (#434)
9f5fb53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bunn Bunn Bunn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mallexxx @Bunn