This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Change service name for NetP auth tokens. #479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 25, 2023
samsymons
approved these changes
Aug 25, 2023
Contributor
samsymons
left a comment
samsymons
left a comment
There was a problem hiding this comment.
LGTM, tested via the macOS PR.
diegoreymendez
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Aug 25, 2023
Task/Issue URL: https://app.asana.com/0/0/1205354504536669/f BSK PR: duckduckgo/BrowserServicesKit#479 iOS PR: duckduckgo/iOS#1956 ## Description An issue is causing the NetP menu to no longer open.
diegoreymendez
added a commit
to duckduckgo/iOS
that referenced
this pull request
Aug 26, 2023
Task/Issue URL: https://app.asana.com/0/0/1205354504536671/f BSK PR: duckduckgo/BrowserServicesKit#479 macOS PR: duckduckgo/macos-browser#1552 ## Description Updates to an upcoming version of BSK.
samsymons
added a commit
that referenced
this pull request
Aug 28, 2023
* main: Change service name for NetP auth tokens. (#479)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1205354504536670/f
iOS PR: duckduckgo/iOS#1956
macOS PR: duckduckgo/macos-browser#1552
What kind of version bump will this require?: Minor
Description
Uses a default for the auth token service that does not depend on the app's bundle ID.
Testing
Test these changes in the iOS and macOS PRs.
Internal references:
Software Engineering Expectations
Technical Design Template