Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error codes to site breakage reports #642

Merged
merged 32 commits into from
Jan 30, 2024
Merged

Add error codes to site breakage reports #642

merged 32 commits into from
Jan 30, 2024

Conversation

jaceklyp
Copy link
Contributor

@jaceklyp jaceklyp commented Jan 30, 2024

Required:

Task/Issue URL: https://app.asana.com/0/72649045549333/1205982573174191/f
iOS PR:
macOS PR:
What kind of version bump will this require?: Major/Minor/Patch

Optional:

Tech Design URL: https://app.asana.com/0/0/1206225370438701/f
CC: @jonathanKingston

Description:
Send error and http status codes within reports

Steps to test this PR:

  1. Load https://expired.badssl.com/
  2. Send report
  3. Put a breakpoint and validate that the report contains error
  4. Validate that the report contains httpErrorCodes too

federicocappelli and others added 28 commits December 14, 2023 10:25
# Conflicts:
#	Sources/PrivacyDashboard/PrivacyDashboardController.swift
Copy link
Member

@federicocappelli federicocappelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one question and one suggestion

Copy link
Member

@federicocappelli federicocappelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested, all good

@jaceklyp jaceklyp merged commit 381cd79 into main Jan 30, 2024
7 checks passed
@jaceklyp jaceklyp deleted the jacek/error-codes branch January 30, 2024 13:17
samsymons added a commit that referenced this pull request Feb 8, 2024
* main:
  add alternateHtmlLoad navigation type (HTML Error Page) (#644)
  Check subfeature state before reading rollout data (#649)
  Add NavigationPreferences CustomHeaderFields (#651)
  Update autofill to 10.1.0 (#643)
  Add Autoconsent onByDefault subfeature (#647)
  Add error codes to site breakage reports (#642)
  Run unit tests also on iOS Simulator (#641)
  Improve VPN auth token storage (#639)
  Bump content-scope-scripts to 4.59.2 (#638)
  Fix `site:` queries escaping with iOS 17 SDK (#640)
  Breakage improvement (#621)
  Don't report CancellationError from BookmarksFaviconsFetcher (#634)
  Add explicit mapping of SyncError to error code (#637)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants