Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove timezone offset from the VPN server object #767

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

samsymons
Copy link
Contributor

@samsymons samsymons commented Apr 9, 2024

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/0/1207032029127388/f
iOS PR: duckduckgo/iOS#2701
macOS PR: duckduckgo/macos-browser#2580
What kind of version bump will this require?: Major

Optional:

Tech Design URL:
CC:

Description:

This PR removes tzOffset from the server object. It wasn't being used and is in the process of being removed.

Steps to test this PR:

  1. See client PRs

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16
  • macOS 10.15
  • macOS 11
  • macOS 12

Internal references:

Software Engineering Expectations
Technical Design Template

@samsymons samsymons requested a review from graeme April 9, 2024 00:58
* main:
  Fix Navigation same-document build flags (no changes in iOS or macOS) (#776)
  Fix VPN bug: Nearest city breaks register requests (#770) (#773)
  Update autofill to 11.0.1 (#769)
@samsymons samsymons merged commit bc70d1a into main Apr 12, 2024
7 checks passed
@samsymons samsymons deleted the sam/remove-tzoffset branch April 12, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants