Skip to content
This repository has been archived by the owner on Jan 10, 2019. It is now read-only.

Fix issue where keyboard loses focus while typing #313

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kwongius
Copy link

Reviewer:
Asana:
CC:

Description: This fixes an issue where the keyboard loses focus while typing.

Steps to reproduce the issue:

  1. Enter a search query and hit enter/search.
  2. While the page is loading, tap on the search bar again and begin typing.
  3. Once the page finally loads, the search box will lose focus. With the patch applied, the search bar no longer loses focus.
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR DRI Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications (Database connections, Grafana stats, CPU)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant