Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor app delegate - final chapter #46

Open
wants to merge 35 commits into
base: main
Choose a base branch
from

Conversation

jaceklyp
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/72649045549333/1208832732122405
CC: @bwaresiak

Description:

  • Thin Launching and Foreground states
  • Make AppStateMachine testable
  • Unit tests for AppStateMachine transitions, AutoClearService, AuthenticationService, UIInteractionManager and LaunchActionsHandler

Steps to test this PR:

  1. Smoke tests. (fetching configs and compilation works)
  2. Make sure the unit tests pass.

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@jaceklyp jaceklyp requested a review from dus7 February 18, 2025 14:31
Copy link
Contributor

@dus7 dus7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks super solid now ✨ . Great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants