Restore iOS token check #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
commented
Feb 20, 2025
Comment on lines
+697
to
+701
| #if os(iOS) | ||
| if (try? await tokenHandler.getToken()) == nil { | ||
| throw TunnelError.startingTunnelWithoutAuthToken(internalError: nil) | ||
| } | ||
| #endif |
There was a problem hiding this comment.
This is the original check, except wrapped in an iOS check as this problem doesn't occur on macOS. I'd rather play it safe and restore this check for iOS-only for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1209441537130420/f
Tech Design URL:
CC:
Description
This PR restores a startup check for the auth token inside the VPN.
Testing Steps
dryRunin the VPN, then starting the VPN on a device and rebooting your phonepixel:m.netp.*.ios.* AND qs_appVersion:7.158.0.3, which shows my own pixels from testing this (I would share a saved search but that Kibana feature doesn't seem to work any more)Impact and Risks
What could go wrong?
Quality Considerations
Notes to Reviewer
Optional E2E tests**:
Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.
Internal references:
Definition of Done | Engineering Expectations | Tech Design Template