Skip to content

Commit

Permalink
POC remove runtime-checks
Browse files Browse the repository at this point in the history
  • Loading branch information
jonathanKingston authored and Shane Osbourne committed Oct 4, 2024
1 parent 3790f24 commit 5f1b514
Show file tree
Hide file tree
Showing 42 changed files with 7 additions and 3,824 deletions.
1 change: 0 additions & 1 deletion CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,3 @@ inject/windows.js @jonathanKingston @q71114 @szanto90balazs

# Test owners
integration-tests/test-pages/ @kdzwinel @jonathanKingston
unit-tests/script-overload-snapshots/ @shakyShane @jonathanKingston @englehardt
4 changes: 2 additions & 2 deletions integration-test/playwright/remote-pages.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ function getHARPath (harFile) {
return path.join(testRoot, 'data', 'har', harFile)
}

const config = './integration-test/test-pages/runtime-checks/config/replace-element.json'
const css = readFileSync('./build/integration/contentScope.js', 'utf8')
const parsedConfig = JSON.parse(readFileSync(config, 'utf8'))
// TODO flag on all features
const parsedConfig = {}

function wrapScript (js, replacements) {
for (const [find, replace] of Object.entries(replacements)) {
Expand Down
17 changes: 0 additions & 17 deletions integration-test/test-pages.js
Original file line number Diff line number Diff line change
Expand Up @@ -71,23 +71,6 @@ describe('Test integration pages', () => {
}
}

describe('Runtime checks', () => {
const pages = {
'runtime-checks/pages/basic-run.html': 'runtime-checks/config/basic-run.json',
'runtime-checks/pages/replace-element.html': 'runtime-checks/config/replace-element.json',
'runtime-checks/pages/filter-props.html': 'runtime-checks/config/filter-props.json',
'runtime-checks/pages/shadow-dom.html': 'runtime-checks/config/shadow-dom.json',
'runtime-checks/pages/script-overload.html': 'runtime-checks/config/script-overload.json',
'runtime-checks/pages/generic-overload.html': 'runtime-checks/config/generic-overload.json'
}
for (const pageName in pages) {
const configName = pages[pageName]
it(`${pageName}`, async () => {
await testPage(pageName, process.cwd() + '/integration-test/test-pages/' + configName)
})
}
})

it('Web compat shims correctness', async () => {
await testPage(
'webcompat/pages/shims.html',
Expand Down
67 changes: 0 additions & 67 deletions integration-test/test-pages/runtime-checks/config/basic-run.json

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

45 changes: 0 additions & 45 deletions integration-test/test-pages/runtime-checks/config/shadow-dom.json

This file was deleted.

Loading

0 comments on commit 5f1b514

Please sign in to comment.