PR feedback

packages/special-pages/pages/new-tab/app/privacy-stats/PrivacyStats.js

@@ -146,6 +146,12 @@ export function Body ({ trackerCompanies, send, ui }) {
     )
 }
 
+/**
+ * Use this when rendered within a widget list.
+ *
+ * It reaches out to access this widget's global visibility, and chooses
+ * whether to incur the side effects (data fetching).
+ */
 export function PrivacyStatsCustomized () {
     const { visibility } = useVisibility()
     if (visibility === 'hidden') {
@@ -158,6 +164,18 @@ export function PrivacyStatsCustomized () {
     )
 }
 
+/**
+ * Use this when you want to render the UI from a context where
+ * the service is available.
+ *
+ * for example:
+ *
+ * ```jsx
+ * <PrivacyStatsProvider>
+ *     <PrivacyStatsConsumer />
+ * </PrivacyStatsProvider>
+ * ```
+ */
 export function PrivacyStatsConsumer () {
     const { state, toggle } = useContext(PrivacyStatsContext)
     if (state.status === 'ready') {

packages/special-pages/pages/new-tab/app/privacy-stats/PrivacyStatsProvider.js

@@ -232,12 +232,12 @@ function useConfigSubscription ({ dispatch, service }) {
 
     useEffect(() => {
         if (!service.current) return console.warn('could not access service')
-        const unsub2 = service.current.onConfig((data) => {
+        const unsub = service.current.onConfig((data) => {
             const animate = !isReducedMotion && data.source === 'manual'
             dispatch({ kind: 'config', config: data.data, animate })
         })
         return () => {
-            unsub2()
+            unsub()
         }
     }, [service, isReducedMotion])