Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DuckPlayer modal experiment updates #1017

Merged
merged 7 commits into from
Aug 29, 2024

Conversation

mgurgel
Copy link
Contributor

@mgurgel mgurgel commented Aug 27, 2024

Asana: https://app.asana.com/0/72649045549333/1208132886429471/f

1. Allows setting focusMode on initialSetup

Updated initialSetup payload

{
	settings: {
		focusMode: {
			state: 'disabled'
		}
		pip: ...
	},
	...
}

2. Implements reactive UI settings to force next video to play in Duck Player

Updated initialSetup payload

{
	ui: {
		playInDuckPlayer: boolean
	},
	userValues: ...
}

New subscription event onUIValuesChanged with payload

{
	playInDuckPlayer: boolean
}

@duckduckgo duckduckgo deleted a comment from github-actions bot Aug 28, 2024
@duckduckgo duckduckgo deleted a comment from github-actions bot Aug 28, 2024
Copy link
Contributor

@shakyShane shakyShane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - just a single point to address :)

@duckduckgo duckduckgo deleted a comment from github-actions bot Aug 29, 2024
Copy link

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@mgurgel mgurgel merged commit 629335f into main Aug 29, 2024
6 checks passed
@mgurgel mgurgel deleted the mgurgel/duckplayer-modal-experiment-comms branch August 29, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants