Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Release Notes button style #1024

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

mgurgel
Copy link
Contributor

@mgurgel mgurgel commented Sep 5, 2024

Asana: https://app.asana.com/0/1206594217596623/1208235498182984/f

A recent update I made to the shared Button component broke its styling in backward-compatibility mode (currently only used by the Release notes special page)

The problem can be seen by running the local server on main and navigating to http://127.0.0.1:3210/build/integration/pages/release-notes/?display=components

image

This fix removes the stray var( properties in the CSS and updates the backward-compatibility selector to body:not([data-platform-name])

How to test this fix:

  1. Check out branch mgurgel/fixes-release-notes-button-style
  2. cd into the packages/special-pages folder
  3. Run npm run watch alongside npm run serve
  4. Navigate to http://127.0.0.1:3210/build/integration/pages/release-notes/?display=components You should see the button styling as shown below

  1. Navigate to http://127.0.0.1:3210/build/integration/pages/special-error/?display=components to confirm there were no changes to the macOS-style button
image
  1. Navigate to http://127.0.0.1:3210/build/integration/pages/special-error/?display=components&platform=ios to confirm there were no changes to the iOS-style button
image

Copy link

github-actions bot commented Sep 5, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@mgurgel mgurgel changed the title Fixed Release Notes button style Fixes Release Notes button style Sep 5, 2024
@mgurgel mgurgel merged commit 17209ff into main Sep 5, 2024
6 checks passed
@mgurgel mgurgel deleted the mgurgel/fixes-release-notes-button-style branch September 5, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants