Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt Stylelint in CI #1025

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Adopt Stylelint in CI #1025

merged 1 commit into from
Oct 18, 2024

Conversation

mgurgel
Copy link
Contributor

@mgurgel mgurgel commented Sep 5, 2024

  • Adds Stylelint scripts to package.json
  • Adds stylelint step to test workflow
  • Initial stylelint config with multiple disabled rules. I suggest we gradually adopt these rules by removing each one from the config, running npm run stylelint-fix and reviewing/committing the resulting changes.

Copy link

github-actions bot commented Sep 18, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@duckduckgo duckduckgo deleted a comment from github-actions bot Oct 14, 2024
@duckduckgo duckduckgo deleted a comment from github-actions bot Oct 14, 2024
@shakyShane
Copy link
Contributor

Just rebasing this and then we can merge

Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit e4b6881
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/671224cc9de933000809076b
😎 Deploy Preview https://deploy-preview-1025--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

[Beta] Generated file diff

Time updated: Fri, 18 Oct 2024 09:06:16 GMT

Integration
    - integration/pages/release-notes/js/index.css
  • integration/pages/special-error/js/index.css

File has changed

Apple
    - dist/pages/release-notes/js/index.css
  • dist/pages/special-error/index.html
  • dist/pages/special-error/js/index.css

File has changed

@shakyShane shakyShane merged commit 94f9bc0 into main Oct 18, 2024
11 checks passed
@shakyShane shakyShane deleted the mgurgel/stylelint branch October 18, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants