Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic page title based on error kind #1034

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Conversation

mgurgel
Copy link
Contributor

@mgurgel mgurgel commented Sep 12, 2024

Asana: https://app.asana.com/0/1206594217596623/1208270234071170/f

  • Sets the page title to match translated heading for that kind of error, e.g.
    • Phishing: "Warning: This site puts your personal information at risk"
    • SSL error: "Warning: This site may be insecure"

Testing

  • Run the macOS app with this branch of C-S-S
  • Follow the steps to reproduce in the Asana task
  • Verify that the page title in the back button popover matches the kind of error

Copy link

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Sep 13, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@mgurgel mgurgel requested a review from shakyShane September 13, 2024 10:04
@not-a-rootkit
Copy link

Sorry I'm only just getting to this now - I've tested this fix and I think it properly addresses this bug: https://app.asana.com/0/1204023833050360/1208270234071170/f. Are we in a position to rebase and merge this?

mgurgel and others added 2 commits October 10, 2024 14:16
Co-authored-by: Shane Osbourne <shane.osbourne8@gmail.com>
@mgurgel mgurgel force-pushed the mgurgel/special-error-page-title branch from 3429220 to 032af7e Compare October 10, 2024 13:16
@mgurgel mgurgel merged commit 347eb3f into main Oct 10, 2024
7 checks passed
@mgurgel mgurgel deleted the mgurgel/special-error-page-title branch October 10, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants