Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new tab page + widget config #1072

Merged
merged 5 commits into from
Sep 25, 2024
Merged

new tab page + widget config #1072

merged 5 commits into from
Sep 25, 2024

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Sep 19, 2024

Added:

Steps to tests

  • npm run build
  • npm run serve-special-pages
  • open http://127.0.0.1:3221/new-tab/
  • open a second, third or forth tab
  • press a toggle - the state will be reflected

@shakyShane
Copy link
Contributor Author

shakyShane commented Sep 19, 2024

@shakyShane shakyShane force-pushed the shane/newtab-initial branch 2 times, most recently from 68df44d to 6f9446a Compare September 24, 2024 14:12
@shakyShane shakyShane changed the title new tab page initial files new tab page + widget config Sep 24, 2024
@shakyShane shakyShane marked this pull request as ready for review September 24, 2024 14:27
@shakyShane shakyShane requested a review from mgurgel as a code owner September 24, 2024 14:27
Copy link

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

mgurgel
mgurgel previously approved these changes Sep 25, 2024
Copy link
Contributor

@mgurgel mgurgel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, and work as expected 👍

Just commented on some leftover code that can be removed in the next round of changes.

Copy link

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@shakyShane shakyShane merged commit 2bbc9c2 into main Sep 25, 2024
6 checks passed
@shakyShane shakyShane deleted the shane/newtab-initial branch September 25, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants