-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ntp: adding icons #1087
ntp: adding icons #1087
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @shakyShane and the rest of your teammates on Graphite |
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if some of these icons inconsistently adding width and height properties rather than just sticking to viewBox might cause problems in the future. But nothing that can’t be fixed forward.
e5f6c46
to
9b259f7
Compare
@mgurgel from experience this tends to not be a problem - these icons are from the official 'export' we have, so I assume those things were considered/tweaked. |
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
https://app.asana.com/0/1201141132935289/1208418410668552/f
Just adding the company icons as a separate commit to reduce PR size :)