Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ntp: adding icons #1087

Merged
merged 1 commit into from
Sep 27, 2024
Merged

ntp: adding icons #1087

merged 1 commit into from
Sep 27, 2024

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Sep 27, 2024

https://app.asana.com/0/1201141132935289/1208418410668552/f

Just adding the company icons as a separate commit to reduce PR size :)

@shakyShane shakyShane mentioned this pull request Sep 27, 2024
3 tasks
@shakyShane
Copy link
Contributor Author

shakyShane commented Sep 27, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @shakyShane and the rest of your teammates on Graphite Graphite

@shakyShane shakyShane marked this pull request as ready for review September 27, 2024 10:03
@shakyShane shakyShane requested a review from mgurgel as a code owner September 27, 2024 10:03
Copy link

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

mgurgel
mgurgel previously approved these changes Sep 27, 2024
Copy link
Contributor

@mgurgel mgurgel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if some of these icons inconsistently adding width and height properties rather than just sticking to viewBox might cause problems in the future. But nothing that can’t be fixed forward.

Base automatically changed from shane/ntp-debug-bar to main September 27, 2024 10:23
@shakyShane shakyShane dismissed mgurgel’s stale review September 27, 2024 10:23

The base branch was changed.

@shakyShane
Copy link
Contributor Author

@mgurgel from experience this tends to not be a problem - these icons are from the official 'export' we have, so I assume those things were considered/tweaked.

Copy link

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@shakyShane shakyShane merged commit 6b9bbd4 into main Sep 27, 2024
6 checks passed
@shakyShane shakyShane deleted the shane/ntp-icons branch September 27, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants