Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release notes generation and build path #1115

Merged
merged 6 commits into from
Oct 17, 2024
Merged

Conversation

jonathanKingston
Copy link
Contributor

@jonathanKingston jonathanKingston commented Oct 16, 2024

Asana Task/Github Issue: https://app.asana.com/0/1201614831475344/1208561434801652/f

Description

Fixes release notes to support multi-line output.

Testing Steps

  • Create new release, or run a draft one by editing the code.

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Copy link

github-actions bot commented Oct 16, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Oct 16, 2024

[Beta] Generated file diff

Time updated: Thu, 17 Oct 2024 08:38:50 GMT

Removed Files - chrome/entry-points.js - chrome-mv3/entry-points.js - firefox/entry-points.js

❌ File only exists in old changeset

New Files - chrome/inject.js - chrome-mv3/inject.js - firefox/inject.js

❌ File only exists in new changeset

@jonathanKingston jonathanKingston force-pushed the jkt/update-latest branch 3 times, most recently from 9bb691c to a2b84c1 Compare October 16, 2024 19:29
@jonathanKingston jonathanKingston changed the title Release debugging Fix release notes generation Oct 16, 2024
@jonathanKingston jonathanKingston marked this pull request as ready for review October 16, 2024 21:43
shakyShane
shakyShane previously approved these changes Oct 17, 2024
Copy link
Contributor

@shakyShane shakyShane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jonathanKingston jonathanKingston merged commit 205d2de into main Oct 17, 2024
7 checks passed
@jonathanKingston jonathanKingston deleted the jkt/update-latest branch October 17, 2024 08:47
@jonathanKingston jonathanKingston changed the title Fix release notes generation Fix release notes generation and build path Oct 17, 2024
vkraucunas pushed a commit that referenced this pull request Oct 17, 2024
* Release debugging

* Make test release

* Add version back in and clean up

* Fix build paths

* Update types back

* Rename out file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants