-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
duckplayer: remove label click trigger on mobile #1121
duckplayer: remove label click trigger on mobile #1121
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @shakyShane and the rest of your teammates on Graphite |
✅ Deploy Preview for content-scope-scripts ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
[Beta] Generated file diffTime updated: Fri, 18 Oct 2024 08:43:38 GMT Android
File has changed Integration
File has changed Windows
File has changed Apple
File has changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Asana Task/Github Issue: https://app.asana.com/0/0/1208542811348500/f
Description
It's common in a web-based UI to have the label wrapping an input, and then click on the label toggle the switch. In the case of iOS/Android this is not as common (if at all)
So this change is just for the mobile devices - we still use an associated label, but we move the trigger to just the switch.
Testing Steps
Checklist
Please tick all that apply: