Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duckplayer: remove label click trigger on mobile #1121

Merged

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Oct 18, 2024

Asana Task/Github Issue: https://app.asana.com/0/0/1208542811348500/f

Description

It's common in a web-based UI to have the label wrapping an input, and then click on the label toggle the switch. In the case of iOS/Android this is not as common (if at all)

So this change is just for the mobile devices - we still use an associated label, but we move the trigger to just the switch.

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@shakyShane
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @shakyShane and the rest of your teammates on Graphite Graphite

Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 9efe35f
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/67121b3bcfa5470008e9ca15
😎 Deploy Preview https://deploy-preview-1121--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Oct 18, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Oct 18, 2024

[Beta] Generated file diff

Time updated: Fri, 18 Oct 2024 08:43:38 GMT

Android
    - android/pages/duckplayer/js/index.css
  • android/pages/duckplayer/js/index.js

File has changed

Integration
    - integration/pages/duckplayer/js/index.css
  • integration/pages/duckplayer/js/index.js

File has changed

Windows
    - windows/pages/duckplayer/js/index.css
  • windows/pages/duckplayer/js/index.js

File has changed

Apple
    - dist/pages/duckplayer/index.html
  • dist/pages/duckplayer/js/index.css
  • dist/pages/duckplayer/js/index.js

File has changed

@shakyShane shakyShane marked this pull request as ready for review October 18, 2024 08:42
@shakyShane shakyShane requested a review from mgurgel as a code owner October 18, 2024 08:42
Copy link
Contributor

@mgurgel mgurgel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shakyShane shakyShane merged commit 4a3528c into main Oct 21, 2024
14 checks passed
@shakyShane shakyShane deleted the 10-18-duckplayer_remove_label_click_trigger_on_mobile branch October 21, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants