Support conditional actions with expectations

[brianhall]

Asana Task/Github Issue: https://app.asana.com/0/481882893211075/1208563922804591/f

Description

Testing Steps

• Run test suite and drag/drop into XCode

Checklist

Please tick all that apply:

• I have tested this change locally
• I have tested this change locally in all supported browsers
• This change will be visible to users
• I have added automated tests that cover this change
• I have ensured the change is gated by config
• This change was covered by a ship review
• This change was covered by a tech design
• Any dependent config has been merged

[github-actions]

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

• Branch Name: pr-releases/pr-1144
• Commit Hash: 23c2dc2dad747bbbe6fe03b78aff753064448c5d
• Install Command: npm i github:duckduckgo/content-scope-scripts#23c2dc2dad747bbbe6fe03b78aff753064448c5d

Please use the above install command to update to the latest version.

[github-actions]

[Beta] Generated file diff

Time updated: Wed, 23 Oct 2024 19:12:41 GMT

Integration

    - integration/contentScope.js

File has changed

Windows

    - windows/contentScope.js

File has changed

Apple

    - dist/contentScopeIsolated.js

File has changed

[netlify]

✅ Deploy Preview for content-scope-scripts ready!

Name	Link
🔨 Latest commit	d491793
🔍 Latest deploy log	https://app.netlify.com/sites/content-scope-scripts/deploys/67194a6e764bb60008d626c1
😎 Deploy Preview	https://deploy-preview-1144--content-scope-scripts.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[shakyShane]

2 miain things I noticed:

1 - we can prevent changing the signatures of the exiting code (see the linked commit)
2 - if you want to execute actions from within another - you need to consider that it's an async operation and capture/communicate those errors for observability. If you already validated that errors are propagated correctly, at the very least we should await each execution to prevent dangling promises.

this commit has a couple of ideas, happy to talk if you need anything 3676158#diff-588b8450ad6aff7276f65312571cd134fa5afb0cd4fc4066d106bd74a47891f7R33-R41

[shakyShane]

Can you check the error text :)