Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Prettier #1198

Merged
merged 23 commits into from
Nov 6, 2024
Merged

Introduce Prettier #1198

merged 23 commits into from
Nov 6, 2024

Conversation

jonathanKingston
Copy link
Contributor

@jonathanKingston jonathanKingston commented Nov 4, 2024

Asana Task/Github Issue: https://app.asana.com/0/0/1208561434802767/f

Description

  • introduce Prettier
  • apply it to the whole codebase

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit b3cc86f
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/672a54399d67fd00082f2c1f
😎 Deploy Preview https://deploy-preview-1198--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Nov 4, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@muodov muodov marked this pull request as draft November 4, 2024 12:51
@muodov muodov changed the title Add prettier Introduce Prettier Nov 5, 2024
@muodov muodov marked this pull request as ready for review November 5, 2024 13:23
@jonathanKingston
Copy link
Contributor Author

@shakyShane can you double check there's not any silly gotchas here? If not I can double check some more tomorrow.

@shakyShane
Copy link
Contributor

@jonathanKingston @muodov I ran this locally - all looks good to me. I think we can merge and just fast-follow with anything small that creeps in. What I've checked

  • I ran npm ci (for a clean run) and verified that npm run lint-fix worked as expected
  • I checked the CI flows, to ensure that prettier is invoked with --check (to prevent merges without formatting)

@muodov muodov merged commit 53818cc into main Nov 6, 2024
13 of 14 checks passed
@muodov muodov deleted the jkt/js-prettier branch November 6, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants