Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: NTP Next Steps Cards FE #1199

Merged
merged 35 commits into from
Nov 13, 2024
Merged

feat: NTP Next Steps Cards FE #1199

merged 35 commits into from
Nov 13, 2024

Conversation

vkraucunas
Copy link
Contributor

@vkraucunas vkraucunas commented Nov 5, 2024

[Sub-project] Frontend - New Tab Page Next Step Cards:Link to Asana Task/Github Issue

Description

  • Adding the NextSteps cards to the New Tab Page

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit ff36ab7
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/6734dcf0334431000861eea1
😎 Deploy Preview https://deploy-preview-1199--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Nov 5, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Nov 5, 2024

[Beta] Generated file diff

Time updated: Wed, 13 Nov 2024 17:09:03 GMT

Integration
    - integration/pages/new-tab/js/index.css
  • integration/pages/new-tab/js/index.js
  • integration/pages/new-tab/js/mock-transport.js
  • integration/pages/new-tab/locales/en/newtab.json

File has changed

Windows
    - windows/pages/new-tab/js/index.css
  • windows/pages/new-tab/js/index.js
  • windows/pages/new-tab/js/mock-transport.js
  • windows/pages/new-tab/locales/en/newtab.json

File has changed

Apple
    - dist/pages/new-tab/js/index.css
  • dist/pages/new-tab/js/index.js
  • dist/pages/new-tab/js/mock-transport.js
  • dist/pages/new-tab/locales/en/newtab.json

File has changed

New Files
    - integration/pages/new-tab/icons/Bring-Stuff-128.svg
  • integration/pages/new-tab/icons/Cookie-Pops-128.svg
  • integration/pages/new-tab/icons/Default-App-128.svg
  • integration/pages/new-tab/icons/Dock-Add-Mac-128.svg
  • integration/pages/new-tab/icons/Dock-Add-Windows-128.svg
  • integration/pages/new-tab/icons/Email-Protection-128.svg
  • integration/pages/new-tab/icons/Tube-Clean-128.svg
  • windows/pages/new-tab/icons/Bring-Stuff-128.svg
  • windows/pages/new-tab/icons/Cookie-Pops-128.svg
  • windows/pages/new-tab/icons/Default-App-128.svg
  • windows/pages/new-tab/icons/Dock-Add-Mac-128.svg
  • windows/pages/new-tab/icons/Dock-Add-Windows-128.svg
  • windows/pages/new-tab/icons/Email-Protection-128.svg
  • windows/pages/new-tab/icons/Tube-Clean-128.svg
  • dist/pages/new-tab/icons/Bring-Stuff-128.svg
  • dist/pages/new-tab/icons/Cookie-Pops-128.svg
  • dist/pages/new-tab/icons/Default-App-128.svg
  • dist/pages/new-tab/icons/Dock-Add-Mac-128.svg
  • dist/pages/new-tab/icons/Dock-Add-Windows-128.svg
  • dist/pages/new-tab/icons/Email-Protection-128.svg
  • dist/pages/new-tab/icons/Tube-Clean-128.svg

❌ File only exists in new changeset

@vkraucunas vkraucunas changed the title feat: NTP NextSteps feat: NTP Next Steps Cards FE Nov 5, 2024
@shakyShane shakyShane marked this pull request as ready for review November 5, 2024 15:19
@shakyShane shakyShane requested review from shakyShane, mgurgel and a team as code owners November 5, 2024 15:19
@shakyShane shakyShane marked this pull request as draft November 5, 2024 15:22
@vkraucunas vkraucunas force-pushed the vkraucunas/ntp-next-steps branch from f4aed51 to 6c63421 Compare November 6, 2024 03:42
@shakyShane shakyShane force-pushed the vkraucunas/ntp-next-steps branch from 8eab4fe to 695b8cc Compare November 6, 2024 15:45
@shakyShane
Copy link
Contributor

shakyShane commented Nov 6, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @vkraucunas and the rest of your teammates on Graphite Graphite

@vkraucunas vkraucunas force-pushed the vkraucunas/ntp-next-steps branch 3 times, most recently from e6419d5 to f572972 Compare November 11, 2024 23:49
@vkraucunas vkraucunas marked this pull request as ready for review November 12, 2024 00:00
Copy link
Contributor

@shakyShane shakyShane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! just a couple of small things to look at - also I think there's an empty file to remove (the MockProvider?)

@vkraucunas vkraucunas force-pushed the vkraucunas/ntp-next-steps branch from fc4bfa3 to ff36ab7 Compare November 13, 2024 17:07
@shakyShane shakyShane merged commit e29058a into main Nov 13, 2024
12 checks passed
@shakyShane shakyShane deleted the vkraucunas/ntp-next-steps branch November 13, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants