messaging: page-world bridge

[shakyShane]

Asana Task/Github Issue: https://app.asana.com/0/1201141132935289/1208740665800207/f

Description

• added a new feature called messageBridge (apple-isolated only for now)
• added createMessageBridge on navigatorInterface - to return the MessagingInterface
  • this is always present, but will throw an exception if the bridge is not allowed, installed or enabled
  • exception is just a generic message, it does not reveal a reason

Testing Steps

• See the macOS PR for where I implemented this E2E [macos] adding support for message bridge macos-browser#3558

Checklist

Please tick all that apply:

• I have tested this change locally
• I have tested this change locally in all supported browsers
• This change will be visible to users
• I have added automated tests that cover this change
• I have ensured the change is gated by config
• This change was covered by a ship review
• This change was covered by a tech design
• Any dependent config has been merged

[shakyShane]

• messaging: page-world bridge #1213 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

• Branch Name: pr-releases/pr-1213
• Commit Hash: 8284be730927b620cc604b1fb8ebe9f24c39021a
• Install Command: npm i github:duckduckgo/content-scope-scripts#8284be730927b620cc604b1fb8ebe9f24c39021a

Please use the above install command to update to the latest version.

[github-actions]

[Beta] Generated file diff

Time updated: Fri, 15 Nov 2024 18:47:54 GMT

Android

    - android/autofillPasswordImport.js

• android/contentScope.js

File has changed

Chrome

    - chrome/inject.js

File has changed

Chrome-mv3

    - chrome-mv3/inject.js

File has changed

Firefox

    - firefox/inject.js

File has changed

Integration

    - integration/contentScope.js

File has changed

Windows

    - windows/contentScope.js

File has changed

Apple

    - dist/contentScope.js

• dist/contentScopeIsolated.js

File has changed

[netlify]

✅ Deploy Preview for content-scope-scripts ready!

Name	Link
🔨 Latest commit	7762e78
🔍 Latest deploy log	https://app.netlify.com/sites/content-scope-scripts/deploys/673797201ef44f0008423b99
😎 Deploy Preview	https://deploy-preview-1213--content-scope-scripts.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[muodov]

The code looks good! I just want to make sure that we give the config structure enough time.

[shakyShane]

I commented on it, maybe it got lost when I pushed more code? Basically this is the version that will allow all the others to be cleaned up, so it’s a first step in that direction, I’ll fast follow with removing all the rest. 

On November 15, 2024, GitHub notifications ***@***.***> wrote: @jonathanKingston commented on this pull request. In injected/integration-test/page-objects/results-collector.js <https://github.com/duckduckgo/content-scope- scripts/pull/1213#discussion_r1844482796>: > @@ -0,0 +1,200 @@ +import { readFileSync } from 'fs'; +import { + mockAndroidMessaging, + mockWebkitMessaging, + mockWindowsMessaging, + simulateSubscriptionMessage, + wrapWebkitScripts, + wrapWindowsScripts, +} from ***@***.***/messaging/lib/test- utils.mjs'; +import { perPlatform } from '../type-helpers.mjs'; + +/** + * This is designed to allow you to execute Playwright tests using the various Why do we keep copying this boilerplate over and over? I get that there are subtle differences but overall this is a lot of code for how small the actual test is. Can we file an issue to clean this up at the minimum?

— Reply to this email directly, view it on GitHub <https://github.com/duckduckgo/content-scope- scripts/pull/1213#pullrequestreview-2439646350>, or unsubscribe <https://github.com/notifications/unsubscribe- auth/AAMRIAR2FQBYQJ3ICEVFQ6T2AZOE3AVCNFSM6AAAAABRSIOBKKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMZZGY2DMMZVGA>. You are receiving this because you were mentioned.Message ID: <duckduckgo/content-scope- ***@***.***>

[jonathanKingston]

There's a few lines we can remove that are commented out.

However we really need to get on top of the boilerplate we're amassing in the tests; can you file a follow up please?

[jonathanKingston]

I’ll fast follow with removing all the rest.

Cool yeah do we need to rethink them all being mapped into that pages test? Happy to cover in a follow up anyway :)

[shakyShane]

I’ll fast follow with removing all the rest.

Cool yeah do we need to rethink them all being mapped into that pages test? Happy to cover in a follow up anyway :)

Yeah, we should just have 2 boiler plates. Extension setup + all the rest. I actually have a branch with this all sorted so I will bring it back to life now that this is getting worse.

[shakyShane]

I'll merge this, and follow immediately with boilerplate removal where possible.