Document settings methods #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for content-scope-scripts ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
[Beta] Generated file diffTime updated: Wed, 13 Nov 2024 14:25:25 GMT Android
File has changed ChromeFile has changed Chrome-mv3File has changed FirefoxFile has changed IntegrationFile has changed WindowsFile has changed Apple
File has changed |
jonathanKingston
force-pushed
the
jkt/documentSettingsKeys
branch
from
3b8315c to
3632c58
Compare
shakyShane
approved these changes
Nov 14, 2024
muodov
reviewed
Nov 20, 2024
| @@ -198,8 +235,10 @@ export default class ContentFeature { | |||
|
|
|||
| /** | |||
| * Given a config key, interpret the value as a list of domain overrides, and return the elements that match the current page | |||
| * Consider using patchSettings instead as per `getFeatureSetting`. | |||
There was a problem hiding this comment.
@jonathanKingston
Hm, I'm not sure what this means. Did you mean "consider using getFeatureSetting instead of this method"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Task/Github Issue: https://app.asana.com/0/481882893211075/1208747188538684/f
Description
Adds some examples of using the feature settings APIs.
Testing Steps
Checklist
Please tick all that apply: