Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes skip link position when debugging #1224

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

mgurgel
Copy link
Contributor

@mgurgel mgurgel commented Nov 14, 2024

Description

As reported by Jonathan L, skip link for version v3 isn’t working. Turns out it’s nested in the <main> element, which places it in the wrong position in the page (red square in image below)

image

Testing Steps

  • Visit the preview link or run locally with query param ?order=v3
  • Open the console
  • Click 5 times on the bottom left of the page
  • Confirm that a dismissToAddressBar notification is dispatched

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@mgurgel mgurgel requested review from shakyShane and a team as code owners November 14, 2024 16:35
Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 5ffb747
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/673626cd386d3e00084ca9fe
😎 Deploy Preview https://deploy-preview-1224--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

[Beta] Generated file diff

Time updated: Thu, 14 Nov 2024 16:36:23 GMT

Integration
    - integration/pages/onboarding/js/index.js

File has changed

Windows
    - windows/pages/onboarding/js/index.js

File has changed

Apple
    - dist/pages/onboarding/js/index.js

File has changed

@mgurgel mgurgel merged commit 6761b7f into main Nov 14, 2024
17 checks passed
@mgurgel mgurgel deleted the mgurgel/skip-link-position branch November 14, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants