Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Tab Page and NTP Widget styles #1229

Merged
merged 37 commits into from
Nov 21, 2024
Merged

New Tab Page and NTP Widget styles #1229

merged 37 commits into from
Nov 21, 2024

Conversation

vkraucunas
Copy link
Contributor

Asana Task/Github Issue: [Sub-project] Frontend - New Tab Page and NTP Widget styles

Description

  • Adds RMF to default NTP view
  • Updates styles on NextSteps
  • Consistency checkon style values

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Copy link

github-actions bot commented Nov 17, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

netlify bot commented Nov 17, 2024

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit c342d13
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/673f8fc20a2a120008beadae
😎 Deploy Preview https://deploy-preview-1229--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Nov 17, 2024

[Beta] Generated file diff

Time updated: Thu, 21 Nov 2024 19:54:39 GMT

Integration
    - integration/pages/new-tab/js/index.css
  • integration/pages/new-tab/js/index.js
  • integration/pages/new-tab/js/mock-transport.js
  • integration/pages/onboarding/js/index.js

File has changed

Windows
    - windows/pages/new-tab/js/index.css
  • windows/pages/new-tab/js/index.js
  • windows/pages/new-tab/js/mock-transport.js
  • windows/pages/onboarding/js/index.js

File has changed

Apple
    - dist/pages/new-tab/js/index.css
  • dist/pages/new-tab/js/index.js
  • dist/pages/new-tab/js/mock-transport.js
  • dist/pages/onboarding/js/index.js

File has changed

@vkraucunas vkraucunas force-pushed the vkraucunas/ntp-styles branch 3 times, most recently from 3824ff1 to f449136 Compare November 20, 2024 16:29
@vkraucunas vkraucunas marked this pull request as ready for review November 21, 2024 01:19
@vkraucunas vkraucunas requested review from shakyShane, mgurgel and a team as code owners November 21, 2024 01:19
@shakyShane shakyShane force-pushed the vkraucunas/ntp-styles branch from 68cc5ec to 59c65b6 Compare November 21, 2024 13:45
shakyShane
shakyShane previously approved these changes Nov 21, 2024
Copy link
Contributor

@shakyShane shakyShane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vkraucunas VERY nice work, thank you for doing this!

@vkraucunas vkraucunas force-pushed the vkraucunas/ntp-styles branch from 6f53c7d to f722e7d Compare November 21, 2024 19:13
@vkraucunas vkraucunas merged commit c9f7798 into main Nov 21, 2024
13 checks passed
@vkraucunas vkraucunas deleted the vkraucunas/ntp-styles branch November 21, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants