Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rollup from 2.75.4 to 2.78.0 #124

Merged
merged 2 commits into from
Aug 18, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 15, 2022

Bumps rollup from 2.75.4 to 2.78.0.

Release notes

Sourced from rollup's releases.

v2.78.0

2022-08-14

Features

  • Support writing plugin hooks as objects with a "handler" property (#4600)
  • Allow changing execution order per plugin hook (#4600)
  • Add flag to execute plugins in async parallel hooks sequentially (#4600)

Pull Requests

v2.77.3

2022-08-11

Bug Fixes

  • Correctly resolve preserveModulesRoot in Vite (#4591)

Pull Requests

v2.77.2

2022-07-27

Bug Fixes

  • Avoid a rendering failure when mixing outputs with inlined and non-inlined dynamic imports (#4589)

Pull Requests

v2.77.1

2.77.1

2022-07-26

Bug Fixes

  • Ensure IIFE output generates a global variable when generating ES5 (#4588)

Pull Requests

... (truncated)

Changelog

Sourced from rollup's changelog.

2.78.0

2022-08-14

Features

  • Support writing plugin hooks as objects with a "handler" property (#4600)
  • Allow changing execution order per plugin hook (#4600)
  • Add flag to execute plugins in async parallel hooks sequentially (#4600)

Pull Requests

2.77.3

2022-08-11

Bug Fixes

  • Correctly resolve preserveModulesRoot in Vite (#4591)

Pull Requests

2.77.2

2022-07-27

Bug Fixes

  • Avoid a rendering failure when mixing outputs with inlined and non-inlined dynamic imports (#4589)

Pull Requests

2.77.1

2022-07-26

Bug Fixes

  • Ensure IIFE output generates a global variable when generating ES5 (#4588)

Pull Requests

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Update one or more dependencies version label Aug 15, 2022
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/main/rollup-2.78.0 branch 3 times, most recently from 3d71e81 to 0de5f5c Compare August 17, 2022 10:30
@jonathanKingston
Copy link
Contributor

Running diff on the generated files it looks like rollup decided to remove a side of the if else branch from xorshift7 imported via seedrandom which is fun!

We should do some canvas verification in case this has impacted generation here at release time; the code now looks correct:

% git diff --text build/firefox/      
diff --git a/build/firefox/inject.js b/build/firefox/inject.js
index e2c7264..73b6066 100644
--- a/build/firefox/inject.js
+++ b/build/firefox/inject.js
@@ -2004,7 +2004,7 @@
       // Enforce an array length of 8, not all zeroes.
       while (X.length < 8) X.push(0);
       for (j = 0; j < 8 && X[j] === 0; ++j);
-      if (j == 8) X[7] = -1;
+      if (j == 8) X[7] = -1; else X[j];
 
       me.x = X;
       me.i = 0;

Snippet from node_modules/seedrandom/lib/xorshift7.js

    // Enforce an array length of 8, not all zeroes.
    while (X.length < 8) X.push(0);
    for (j = 0; j < 8 && X[j] === 0; ++j);
    if (j == 8) w = X[7] = -1; else w = X[j];

Time to go read reflections on trusting trust again!

dependabot bot and others added 2 commits August 18, 2022 15:37
Bumps [rollup](https://github.com/rollup/rollup) from 2.75.4 to 2.78.0.
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v2.75.4...v2.78.0)

---
updated-dependencies:
- dependency-name: rollup
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@jonathanKingston jonathanKingston force-pushed the dependabot/npm_and_yarn/main/rollup-2.78.0 branch from e7e5eb4 to 0bd0272 Compare August 18, 2022 14:38
@jonathanKingston
Copy link
Contributor

@SlayterDev are you able to review this so we can release another tag.

@jonathanKingston jonathanKingston merged commit 1fe2f59 into main Aug 18, 2022
@jonathanKingston jonathanKingston deleted the dependabot/npm_and_yarn/main/rollup-2.78.0 branch August 18, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update one or more dependencies version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants