Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ntp: add url to open action #1248

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Nov 20, 2024

Asana Task/Github Issue: https://app.asana.com/0/1201141132935289/1208809262760054/f

Description

Added 'url' to favorites open action

Testing Steps

  • Covered in the automated tests

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 85792a1
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/673e05f9bf97570008eebbcf
😎 Deploy Preview https://deploy-preview-1248--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shakyShane
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Nov 20, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@shakyShane shakyShane marked this pull request as ready for review November 20, 2024 15:54
@shakyShane shakyShane requested review from mgurgel and a team as code owners November 20, 2024 15:54
Copy link

github-actions bot commented Nov 20, 2024

[Beta] Generated file diff

Time updated: Wed, 20 Nov 2024 15:55:07 GMT

Integration
    - integration/pages/new-tab/js/index.js

File has changed

Windows
    - windows/pages/new-tab/js/index.js

File has changed

Apple
    - dist/pages/new-tab/js/index.js

File has changed

@shakyShane shakyShane merged commit 2a88cb0 into main Nov 20, 2024
20 checks passed
@shakyShane shakyShane deleted the 11-20-ntp_add_url_to_open_action branch November 20, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants