Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ntp: handle drag + drop outside of favorites #1256

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Nov 22, 2024

Asana Task/Github Issue: https://app.asana.com/0/1201141132935289/1208717262504806/f

Description

  • We need to prevent responding to arbitrary drops, otherwise the browser pops open a new window
  • Added a graceful way to handle fatal exceptions (we now display them in the page for debugging/integration)

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 7a6d730
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/674083a377ab9800084d7675
😎 Deploy Preview https://deploy-preview-1256--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shakyShane
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Nov 22, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Nov 22, 2024

[Beta] Generated file diff

Time updated: Fri, 22 Nov 2024 13:15:09 GMT

Integration
    - integration/pages/new-tab/js/index.css
  • integration/pages/new-tab/js/index.js

File has changed

Windows
    - windows/pages/new-tab/js/index.css
  • windows/pages/new-tab/js/index.js

File has changed

Apple
    - dist/pages/new-tab/js/index.css
  • dist/pages/new-tab/js/index.js

File has changed

@shakyShane shakyShane marked this pull request as ready for review November 22, 2024 10:11
@shakyShane shakyShane requested review from mgurgel and a team as code owners November 22, 2024 10:11
mgurgel
mgurgel previously approved these changes Nov 22, 2024
Copy link
Contributor

@mgurgel mgurgel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

@shakyShane
Copy link
Contributor Author

I've tested this in the browser - works well :)

@shakyShane shakyShane merged commit ae441a9 into main Nov 22, 2024
15 checks passed
@shakyShane shakyShane deleted the 11-22-ntp_handle_drag_drop_outside_of_favorites branch November 22, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants