Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ntp: prepare translations #1262

Merged
merged 12 commits into from
Nov 25, 2024
Merged

ntp: prepare translations #1262

merged 12 commits into from
Nov 25, 2024

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Nov 22, 2024

Asana Task/Github Issue: https://app.asana.com/0/1201141132935289/1208831856736789/f

Description

  • split the translations into separate strings.json files
  • combine them during the build process, so that we still get a single output file in src/locales/en/new-tab.json
    • this file is the one we then submit to smartling
  • I applied the ship review feedback around copy
  • I improved the notes for translators

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@shakyShane
Copy link
Contributor Author

shakyShane commented Nov 22, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 83ea26e
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/674462de397e5e0008855eed
😎 Deploy Preview https://deploy-preview-1262--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Nov 22, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Nov 22, 2024

[Beta] Generated file diff

Time updated: Mon, 25 Nov 2024 11:44:23 GMT

Integration
    - integration/pages/new-tab/js/index.css
  • integration/pages/new-tab/js/index.js

File has changed

Removed Files
    - integration/pages/new-tab/js/mock-transport.js
  • integration/pages/new-tab/locales/en/newtab.json
  • windows/pages/new-tab/js/mock-transport.js
  • windows/pages/new-tab/locales/en/newtab.json
  • dist/pages/new-tab/js/mock-transport.js
  • dist/pages/new-tab/locales/en/newtab.json

❌ File only exists in old changeset

Windows
    - windows/pages/new-tab/js/index.css
  • windows/pages/new-tab/js/index.js

File has changed

Apple
    - dist/pages/new-tab/js/index.css
  • dist/pages/new-tab/js/index.js

File has changed

New Files
    - integration/pages/new-tab/locales/en/.gitignore
  • integration/pages/new-tab/locales/en/new-tab.json
  • windows/pages/new-tab/locales/en/.gitignore
  • windows/pages/new-tab/locales/en/new-tab.json
  • dist/pages/new-tab/locales/en/.gitignore
  • dist/pages/new-tab/locales/en/new-tab.json

❌ File only exists in new changeset

@shakyShane shakyShane force-pushed the shane/ntp-translations branch from 6d123d8 to c069050 Compare November 22, 2024 20:36
@shakyShane shakyShane mentioned this pull request Nov 22, 2024
8 tasks
@shakyShane shakyShane changed the title ntp: modular translations ntp: prepare translations Nov 24, 2024
@shakyShane shakyShane marked this pull request as ready for review November 24, 2024 08:00
@shakyShane shakyShane requested review from mgurgel and a team as code owners November 24, 2024 08:00
@shakyShane shakyShane assigned mgurgel and unassigned vkraucunas Nov 24, 2024
@shakyShane shakyShane merged commit 0965ca1 into main Nov 25, 2024
12 checks passed
@shakyShane shakyShane deleted the shane/ntp-translations branch November 25, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants