Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special Pages: Malware warning support #1268

Merged
merged 12 commits into from
Dec 6, 2024
Merged

Special Pages: Malware warning support #1268

merged 12 commits into from
Dec 6, 2024

Conversation

mgurgel
Copy link
Contributor

@mgurgel mgurgel commented Nov 25, 2024

Asana Task/Github Issue: https://app.asana.com/0/0/1208033567421355/f

Description

Adds Malware warning page to Special Error pages.

initialSetup message changed to accommodate additional params. More info here: https://app.asana.com/0/1206594217596623/1208824527069247/f

Testing Steps

  1. View the previews:
    1. Phishing
    2. Malware
  2. Copy, layout and functionality must match Figma

Checklist

<!—
These questions are a friendly reminder to shipping code, if you're uncertain ask the AoR owners.
It's also totally appropriate to not check some of these boxes, if they don't apply to your change.
—>
Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@mgurgel mgurgel requested review from shakyShane and a team as code owners November 25, 2024 13:38
Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 127adde
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/6752fbf024e33d000887cc4e
😎 Deploy Preview https://deploy-preview-1268--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Nov 25, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Nov 25, 2024

[Beta] Generated file diff

Time updated: Fri, 06 Dec 2024 13:29:13 GMT

Removed Files
    - integration/pages/special-error/js/Phishing-64-FB4XJ4DQ.svg
  • dist/pages/special-error/js/Phishing-64-FB4XJ4DQ.svg

❌ File only exists in old changeset

Integration
    - integration/pages/special-error/js/index.css
  • integration/pages/special-error/js/index.js
  • integration/pages/special-error/js/sampleData.js
  • integration/pages/special-error/locales/en/special-error.json

File has changed

Apple
    - dist/pages/special-error/index.html
  • dist/pages/special-error/js/index.css
  • dist/pages/special-error/js/index.js
  • dist/pages/special-error/js/sampleData.js
  • dist/pages/special-error/locales/en/special-error.json

File has changed

New Files
    - integration/pages/special-error/js/Malware-Site-96-A35AQOKY.svg
  • integration/pages/special-error/js/mock-transport.js
  • dist/pages/special-error/js/Malware-Site-96-A35AQOKY.svg
  • dist/pages/special-error/js/mock-transport.js

❌ File only exists in new changeset

@mgurgel mgurgel changed the title [WIP] Special Pages: Malware warning support Special Pages: Malware warning support Dec 2, 2024
@mgurgel mgurgel self-assigned this Dec 2, 2024
@mgurgel mgurgel requested a review from shakyShane December 2, 2024 18:10
shakyShane
shakyShane previously approved these changes Dec 3, 2024
Copy link
Contributor

@shakyShane shakyShane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

shakyShane
shakyShane previously approved these changes Dec 6, 2024
@mgurgel mgurgel merged commit 9322e51 into main Dec 6, 2024
13 checks passed
@mgurgel mgurgel deleted the mgurgel/malware branch December 6, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants