Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ntp: add telemetry events for show/hide #1280

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Nov 26, 2024

Asana Task/Github Issue: https://app.asana.com/0/0/1208847634923418/f

Description

  • added a generic telemetry event setup
    • this can be used to observe actions in the FE

Testing Steps

image

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@shakyShane
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Nov 26, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit d250d2e
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/674627807ffba50008627ccf
😎 Deploy Preview https://deploy-preview-1280--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Nov 26, 2024

[Beta] Generated file diff

Time updated: Tue, 26 Nov 2024 19:55:38 GMT

Integration
    - integration/pages/new-tab/js/index.js

File has changed

Windows
    - windows/pages/new-tab/js/index.js

File has changed

Apple
    - dist/pages/new-tab/js/index.js

File has changed

@shakyShane shakyShane marked this pull request as ready for review November 26, 2024 17:46
@shakyShane shakyShane requested review from mgurgel and a team as code owners November 26, 2024 17:46
vkraucunas
vkraucunas previously approved these changes Nov 26, 2024
@shakyShane shakyShane merged commit f7d3172 into main Nov 26, 2024
14 checks passed
@shakyShane shakyShane deleted the 11-26-ntp_add_telemetry_events_for_show_hide branch November 26, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants