Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ntp: favicon fixes #1286

Merged
merged 1 commit into from
Nov 27, 2024
Merged

ntp: favicon fixes #1286

merged 1 commit into from
Nov 27, 2024

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Nov 27, 2024

Asana Task/Github Issue: https://app.asana.com/0/1201141132935289/1208857757578312/f

Description

  • the first icon here is the fallback
  • the second icon shows a larger size, but not exceeding what we allow (32px)
  • the third show that we dont scale-up the icon if it's too small.

image

Testing Steps

  • You need to test this in place, which I've done

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@shakyShane
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Nov 27, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit c821a0e
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/674742fd6e90b100087c4fa8
😎 Deploy Preview https://deploy-preview-1286--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Nov 27, 2024

[Beta] Generated file diff

Time updated: Wed, 27 Nov 2024 16:05:14 GMT

Integration
    - integration/pages/new-tab/js/index.css
  • integration/pages/new-tab/js/index.js

File has changed

Windows
    - windows/pages/new-tab/js/index.css
  • windows/pages/new-tab/js/index.js

File has changed

Apple
    - dist/pages/new-tab/js/index.css
  • dist/pages/new-tab/js/index.js

File has changed

@shakyShane shakyShane marked this pull request as ready for review November 27, 2024 15:42
@shakyShane shakyShane requested review from mgurgel and a team as code owners November 27, 2024 15:42
@shakyShane shakyShane force-pushed the 11-27-ntp_favicon_fixes branch from 781c3ab to c821a0e Compare November 27, 2024 16:04
@shakyShane shakyShane merged commit b3babe6 into main Nov 27, 2024
13 checks passed
@shakyShane shakyShane deleted the 11-27-ntp_favicon_fixes branch November 27, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants