Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ntp: customizer drawer #1291

Merged
merged 4 commits into from
Dec 2, 2024
Merged

ntp: customizer drawer #1291

merged 4 commits into from
Dec 2, 2024

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Dec 1, 2024

Asana Task/Github Issue: https://app.asana.com/0/1201141132935289/1208879908085793/f

Description

  • added the global setup for the customizer drawer
  • everything is behind a flag, so this can be merged/released without affecting production 💪
  • 100% focus on performance 🚀
    • uses Preact signals directly on DOM attributes to trigger the global grid animation - this prevents all VDOM diffing, making it instantaneous even on the lowest powered devices
    • Rendering of children inside the drawer is deferred, to further prevent main-thread work whilst the animation is playing

Testing Steps

WITHOUT feature flag
image

WITH feature flag

NOTE: It's deliberately not including panel content, styles or anything else, this PR is designed to be small and just focus on the infrastructure changes needed.

image

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@shakyShane
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

netlify bot commented Dec 1, 2024

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 90d651f
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/674d9b93bd924400082be95e
😎 Deploy Preview https://deploy-preview-1291--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Dec 1, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Dec 1, 2024

[Beta] Generated file diff

Time updated: Mon, 02 Dec 2024 11:36:45 GMT

Integration
    - integration/pages/new-tab/js/index.css
  • integration/pages/new-tab/js/index.js

File has changed

Windows
    - windows/pages/new-tab/js/index.css
  • windows/pages/new-tab/js/index.js

File has changed

Apple
    - dist/pages/new-tab/js/index.css
  • dist/pages/new-tab/js/index.js

File has changed

@shakyShane shakyShane force-pushed the 12-01-ntp_customizer_drawer branch from bf6fd7d to 692559e Compare December 1, 2024 22:12
@shakyShane shakyShane marked this pull request as ready for review December 2, 2024 07:39
@shakyShane shakyShane requested review from mgurgel and a team as code owners December 2, 2024 07:39
mgurgel
mgurgel previously approved these changes Dec 2, 2024
@shakyShane shakyShane merged commit b1e6f22 into main Dec 2, 2024
14 checks passed
@shakyShane shakyShane deleted the 12-01-ntp_customizer_drawer branch December 2, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants