Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy review - Phishing warning page #1313

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Conversation

mgurgel
Copy link
Contributor

@mgurgel mgurgel commented Dec 9, 2024

Asana Task/Github Issue: https://app.asana.com/0/38424471409662/1208863401278206/f

Description

Updates Phishing warning page copy:

  • Phishing warning header: "Warning: This site may put your personal information at risk”
  • Phishing warning advanced description: "If you believe this website is safe, you can report an error. You can still visit the website at your own risk. Accept Risk and Visit Site"

Testing Steps

  1. Open the preview or run locally with npm run build && npm run serve-static-pages, then open http://127.0.0.1:3221/special-error/?errorId=phishing
  2. Check that page copy matches description above

Checklist

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@mgurgel mgurgel requested review from shakyShane and a team as code owners December 9, 2024 12:53
Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 78f82b6
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/67600d81fa01720008a7b283
😎 Deploy Preview https://deploy-preview-1313--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Dec 9, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Dec 9, 2024

[Beta] Generated file diff

Time updated: Mon, 16 Dec 2024 11:23:44 GMT

Integration
    - integration/pages/special-error/js/index.js
  • integration/pages/special-error/locales/en/special-error.json

File has changed

Apple
    - dist/pages/special-error/index.html
  • dist/pages/special-error/js/index.js
  • dist/pages/special-error/locales/en/special-error.json

File has changed

@mgurgel mgurgel force-pushed the mgurgel/malware-copy-review branch from f07deca to 78f82b6 Compare December 16, 2024 11:22
@mgurgel mgurgel merged commit edaefff into main Dec 16, 2024
12 checks passed
@mgurgel mgurgel deleted the mgurgel/malware-copy-review branch December 16, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants