-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NTP: FE - Freemium PIR Banner #1315
Conversation
✅ Deploy Preview for content-scope-scripts ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
[Beta] Generated file diffTime updated: Mon, 16 Dec 2024 16:50:32 GMT Integration
File has changed Windows
File has changed Apple
File has changed New Files
❌ File only exists in new changeset |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work - just a quick request on one of the schemas :)
special-pages/pages/new-tab/messages/types/freemiumPIRBanner-message.json
Show resolved
Hide resolved
special-pages/pages/new-tab/app/freemium-pir-banner/components/FreemiumPIRBanner.js
Outdated
Show resolved
Hide resolved
special-pages/pages/new-tab/app/freemium-pir-banner/components/FreemiumPIRBanner.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vkraucunas This will need a quick rebase now I believe, and can you also add something along the lines of https://github.com/duckduckgo/content-scope-scripts/compare/vkraucunas/freemium-pir-banner...shane/freemium-update?expand=1
^ just an example - I don't expect this is an XSS attack area (it's not user input after all), but since it's an area of the system we don't control I'd like us to be cautious with any HTML
38f40c2
to
124ce86
Compare
Co-authored-by: Shane Osbourne <shane.osbourne8@gmail.com>
dfee2c9
to
20b4942
Compare
Asana Task/Github Issue: https://app.asana.com/0/72649045549333/1208964501989233/f
Description
Testing Steps
Checklist
Please tick all that apply: