Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTP: FE - Freemium PIR Banner #1315

Merged
merged 20 commits into from
Dec 16, 2024
Merged

NTP: FE - Freemium PIR Banner #1315

merged 20 commits into from
Dec 16, 2024

Conversation

vkraucunas
Copy link
Contributor

@vkraucunas vkraucunas commented Dec 12, 2024

Asana Task/Github Issue: https://app.asana.com/0/72649045549333/1208964501989233/f

Description

  • Adds a Freemium PIR banner, leveraging the RMF component styles as a start

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 20b4942
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/67605a191e1fa20008679a9e
😎 Deploy Preview https://deploy-preview-1315--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Dec 12, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Dec 12, 2024

[Beta] Generated file diff

Time updated: Mon, 16 Dec 2024 16:50:32 GMT

Integration
    - integration/pages/new-tab/dist/index.css
  • integration/pages/new-tab/dist/index.js

File has changed

Windows
    - windows/pages/new-tab/dist/index.css
  • windows/pages/new-tab/dist/index.js

File has changed

Apple
    - dist/pages/new-tab/dist/index.css
  • dist/pages/new-tab/dist/index.js

File has changed

New Files
    - integration/pages/new-tab/icons/Information-Remover-96.svg
  • windows/pages/new-tab/icons/Information-Remover-96.svg
  • dist/pages/new-tab/icons/Information-Remover-96.svg

❌ File only exists in new changeset

@vkraucunas vkraucunas marked this pull request as ready for review December 13, 2024 18:04
@vkraucunas vkraucunas requested review from shakyShane, mgurgel and a team as code owners December 13, 2024 18:04
Copy link
Contributor

@shakyShane shakyShane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work - just a quick request on one of the schemas :)

Copy link
Contributor

@shakyShane shakyShane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vkraucunas This will need a quick rebase now I believe, and can you also add something along the lines of https://github.com/duckduckgo/content-scope-scripts/compare/vkraucunas/freemium-pir-banner...shane/freemium-update?expand=1

^ just an example - I don't expect this is an XSS attack area (it's not user input after all), but since it's an area of the system we don't control I'd like us to be cautious with any HTML

@vkraucunas vkraucunas force-pushed the vkraucunas/freemium-pir-banner branch from 38f40c2 to 124ce86 Compare December 16, 2024 15:48
@vkraucunas vkraucunas force-pushed the vkraucunas/freemium-pir-banner branch from dfee2c9 to 20b4942 Compare December 16, 2024 16:49
@vkraucunas vkraucunas merged commit 7ef4778 into main Dec 16, 2024
13 checks passed
@vkraucunas vkraucunas deleted the vkraucunas/freemium-pir-banner branch December 16, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants