Add Chrome MV3 build target #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzar
force-pushed
the
mv3-script-injection-register
branch
6 times, most recently
from
df0914a to
98f1042
Compare
kzar
force-pushed
the
mv3-script-injection-register
branch
from
98f1042 to
c232072
Compare
Add a Chrome MV3 build target, that produces a main-world content
script ready for injection. Since there is not yet a way to pass
arguments to chrome.scripting.registerContentScript[1] registered
content scripts, generate a secret in the main-world (before the
website's own scripts have a chance to run) and emit that as an event
for our content script. That way, the main-world script still has a
way to share a secret with the content script for messaging.
Note: The registerContentScript does not yet allow about:blank frames
to be targeted[2].
1 - https://developer.chrome.com/docs/extensions/reference/scripting/#method-registerContentScripts
2 - https://crbug.com/1360392
kzar
force-pushed
the
mv3-script-injection-register
branch
from
c232072 to
ce8ed92
Compare
jonathanKingston
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a Chrome MV3 build target, that produces a main-world content
script ready for injection. Since there is not yet a way to pass
arguments to chrome.scripting.registerContentScript[1] registered
content scripts, generate a secret in the main-world (before the
website's own scripts have a chance to run) and emit that as an event
for our content script. That way, the main-world script still has a
way to share a secret with the content script for messaging.
Note: The registerContentScript does not yet allow about:blank frames
to be targeted[2].
1 - https://developer.chrome.com/docs/extensions/reference/scripting/#method-registerContentScripts
2 - https://crbug.com/1360392