Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify tab checks #154

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Simplify tab checks #154

merged 1 commit into from
Oct 4, 2022

Conversation

jonathanKingston
Copy link
Contributor

@jonathanKingston jonathanKingston commented Sep 29, 2022 •
edited
Loading

Changes:

  • Renames getTabOrigin to getTabHostname
  • Remove getTopLevelURL and replace with getTabHostname
  • Explain that args.site.domain is still preferred; this is because in Firefox the URL will come from the background and circumvent the sandboxed iframe limitations that make the response of the method wrong.
  • Type the processConfig method
  • Change isUnprotectedDomain to accept a hostname instead of a URL object; this simplifies the code further.
  • Add a .vscode config file as the generated files being in search is time consuming.

shakyShane
shakyShane requested changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@shakyShane shakyShane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small about comment about using Record

@jonathanKingston jonathanKingston removed the request for review from dharb October 4, 2022 14:34
@jonathanKingston jonathanKingston merged commit 454e4d4 into main Oct 4, 2022
@jonathanKingston jonathanKingston deleted the jkt/simplify-tab-check branch October 4, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shakyShane shakyShane shakyShane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathanKingston @shakyShane