Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Learn More link on Phishing page #969

Merged
merged 12 commits into from
Jun 4, 2024
Merged

Learn More link on Phishing page #969

merged 12 commits into from
Jun 4, 2024

Conversation

mgurgel
Copy link
Contributor

@mgurgel mgurgel commented May 31, 2024 •
edited
Loading

Asana: https://app.asana.com/0/1206594217596623/1207336102226041
Reviewer: @shakyShane @not-a-rootkit

  • Implements Learn More link in Phishing warning error page
  • Integration tests
  • Minor fixes and CSS code styling

@mgurgel mgurgel changed the title [WIP] Learn More link on Phishing page Learn More link on Phishing page Jun 4, 2024
@mgurgel mgurgel requested a review from not-a-rootkit June 4, 2024 13:11
@mgurgel mgurgel self-assigned this Jun 4, 2024
not-a-rootkit
not-a-rootkit approved these changes Jun 4, 2024
View reviewed changes
Copy link

@not-a-rootkit not-a-rootkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good - thanks for doing the tests too @mgurgel!

@not-a-rootkit not-a-rootkit merged commit 84a312d into tespach/phishing-error-page Jun 4, 2024
4 checks passed
@not-a-rootkit not-a-rootkit deleted the mgurgel/phishing-error-page branch June 4, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@not-a-rootkit not-a-rootkit not-a-rootkit approved these changes

@jonathanKingston jonathanKingston Awaiting requested review from jonathanKingston jonathanKingston is a code owner

@shakyShane shakyShane Awaiting requested review from shakyShane shakyShane is a code owner

Assignees

@mgurgel mgurgel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgurgel @not-a-rootkit