fix: check if form elements are iterable

duckduckgo · Aug 7, 2024 · 48ea818 · 48ea818
1 parent a3bab7d
commit 48ea818
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 6 deletions.
diff --git a/dist/autofill-debug.js b/dist/autofill-debug.js
diff --git a/dist/autofill.js b/dist/autofill.js
diff --git a/src/Form/Form.js b/src/Form/Form.js
@@ -400,8 +400,8 @@ class Form {
         } else {
             /** @type {Element[] | NodeList} */
             let foundInputs = []
-
-            if (this.form instanceof HTMLFormElement) {
+            // Some sites seem to be overriding `form.elements`, so we need to check if it's still iterable, otherwise we break the site.
+            if (this.form instanceof HTMLFormElement && Symbol.iterator in Object(this.form.elements)) {
                 // For form elements we use .elements to catch fields outside the form itself using the form attribute.
                 // It also catches all elements when the markup is broken.
                 // We use .filter to avoid fieldset, button, textarea etc.

diff --git a/swift-package/Resources/assets/autofill-debug.js b/swift-package/Resources/assets/autofill-debug.js
diff --git a/swift-package/Resources/assets/autofill.js b/swift-package/Resources/assets/autofill.js