Skip to content

Commit

Permalink
Update email protection copy to align with mobile (#362)
Browse files Browse the repository at this point in the history
  • Loading branch information
alistairjcbrown committed Aug 2, 2023
1 parent 802438a commit cd17237
Show file tree
Hide file tree
Showing 9 changed files with 20 additions and 20 deletions.
6 changes: 3 additions & 3 deletions dist/autofill-debug.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions dist/autofill.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion integration-test/helpers/pages.js
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ export function signupPage (page) {
* @param {string} address
*/
async selectPrivateAddress (address) {
await page.getByRole('button', { name: `Generate Private Duck Address ${address} Blocks email trackers and hides your address` })
await page.getByRole('button', { name: `Generate Private Duck Address ${address} Block email trackers & hide address` })
.click({force: true})
}
/**
Expand Down
4 changes: 2 additions & 2 deletions integration-test/tests/email-autofill.extension.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ test.describe('chrome extension', () => {
await emailPage.clickIntoInput()

// buttons, unique to the extension
const personalAddressBtn = await page.locator(`text=Use ${personalAddress} Blocks email trackers`)
const privateAddressBtn = await page.locator(`text=Generate a Private Duck Address Blocks email trackers and hides your address`)
const personalAddressBtn = await page.locator(`text=Use ${personalAddress} Block email trackers`)
const privateAddressBtn = await page.locator(`text=Generate a Private Duck Address Block email trackers & hide address`)

// click first option
await personalAddressBtn.click({timeout: 500})
Expand Down
2 changes: 1 addition & 1 deletion integration-test/tests/email-autofill.macos.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ test.describe('macos', () => {
await emailPage.clickIntoInput()

// these are mac specific - different to the extension because they use different tooltips (currently)
const personalAddressBtn = await page.locator(`button:has-text("${personalAddress} Blocks email trackers")`)
const personalAddressBtn = await page.locator(`button:has-text("${personalAddress} Block email trackers")`)
const privateAddressBtn = await page.locator(`button:has-text("Generate Private Duck Address 0@duck.com")`)

// select the first option
Expand Down
4 changes: 2 additions & 2 deletions src/DeviceInterface/InterfacePrototype.js
Original file line number Diff line number Diff line change
Expand Up @@ -163,14 +163,14 @@ class InterfacePrototype {
newIdentities.push({
id: 'personalAddress',
emailAddress: personalAddress,
title: 'Blocks email trackers'
title: 'Block email trackers'
})
}

newIdentities.push({
id: 'privateAddress',
emailAddress: privateAddress,
title: 'Blocks email trackers and hides your address'
title: 'Block email trackers & hide address'
})

return [...identities, ...newIdentities]
Expand Down
4 changes: 2 additions & 2 deletions src/UI/EmailHTMLTooltip.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,11 @@ ${this.options.css}
<span class="tooltip__button--email__primary-text">
Use <span class="js-address">${formatDuckAddress(escapeXML(this.addresses.personalAddress))}</span>
</span>
<span class="tooltip__button--email__secondary-text">Blocks email trackers</span>
<span class="tooltip__button--email__secondary-text">Block email trackers</span>
</button>
<button class="tooltip__button tooltip__button--email js-use-private">
<span class="tooltip__button--email__primary-text">Generate a Private Duck Address</span>
<span class="tooltip__button--email__secondary-text">Blocks email trackers and hides your address</span>
<span class="tooltip__button--email__secondary-text">Block email trackers & hide address</span>
</button>
</div>
<div class="tooltip--email__caret"></div>
Expand Down
6 changes: 3 additions & 3 deletions swift-package/Resources/assets/autofill-debug.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions swift-package/Resources/assets/autofill.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit cd17237

Please sign in to comment.