Fix form submission overtriggering (#324)

Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>
duckduckgo · May 26, 2023 · d1558f7 · d1558f7
1 parent 084ba7b
commit d1558f7
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 0 deletions.
diff --git a/dist/autofill-debug.js b/dist/autofill-debug.js
diff --git a/dist/autofill.js b/dist/autofill.js
diff --git a/src/DeviceInterface/initFormSubmissionsApi.js b/src/DeviceInterface/initFormSubmissionsApi.js
@@ -82,6 +82,10 @@ export function initFormSubmissionsApi (forms) {
  if (!entries.length) return
 
  const filledForm = [...forms.values()].find(form => form.hasValues())
+ const focusedForm = [...forms.values()].find((form) => form.hasFocus())
+ // If a form is still focused the user is still typing: do nothing
+ if (focusedForm) return
+
  filledForm?.submitHandler('performance observer')
  })
  observer.observe({entryTypes: ['resource']})

diff --git a/swift-package/Resources/assets/autofill-debug.js b/swift-package/Resources/assets/autofill-debug.js
diff --git a/swift-package/Resources/assets/autofill.js b/swift-package/Resources/assets/autofill.js