Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type consistency internally + when consumed #247

Merged
merged 3 commits into from
Jan 17, 2023
Merged

Conversation

shakyShane
Copy link
Collaborator

@shakyShane shakyShane commented Jan 15, 2023

Reviewer: @GioSensation
Asana: https://app.asana.com/0/0/1203762099790343/f

Description

This helps to fix #245 (comment)

By always using .ts files internally, we can ensure that types are checked in the same way that they would be by consumers

Steps to test

  • No functional changes at all - you can verify this because the build doesn't produce any changes to the artifacts (in the first commit, the second has password rules updates)

@github-actions
Copy link

Note: Password rules outdated

auth.readymag.com not present in current
	rules: minlength: 8; maxlength: 128; required: lower; required: upper; allowed: special;

You can update the rules with the following command

cd packages/password && npm run rules:update

Once you've updated the rules, re-run the build from the root with npm run build and then commit all changes.

@shakyShane shakyShane changed the title shane/types-file Type consistency internally + when consumed Jan 15, 2023
Copy link
Member

@GioSensation GioSensation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for looking into this! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants