Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use node v18 and update actions to read .nvmrc file #269

Merged
merged 1 commit into from
Mar 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/asana-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,9 @@ jobs:
- uses: actions/checkout@v3
with:
path: autofill/
- name: Use Node.js 16
uses: actions/setup-node@v3
- uses: actions/setup-node@v3
with:
node-version: 16.x
node-version-file: '.nvmrc'

- name: Create Asana Tasks
id: create-asana-tasks
Expand Down
17 changes: 8 additions & 9 deletions .github/workflows/password-rules.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,10 @@ jobs:
test:
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v2
- name: Use Node.js 16
uses: actions/setup-node@v1
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16.x
node-version-file: '.nvmrc'
- uses: actions/cache@v2
with:
path: ~/.npm
Expand All @@ -25,14 +24,14 @@ jobs:
script: |
const current = require('./packages/password/rules.json')
const {summary, intoMarkdown, REMOTE_URL} = require('./packages/password/scripts/rules.js')
const result = await github.request(REMOTE_URL);
const lines = summary(current, JSON.parse(result.data));
const result = await github.request(REMOTE_URL);
const lines = summary(current, JSON.parse(result.data));

if (lines.length === 0) return;

await github.rest.issues.createComment({
issue_number: context.issue.number,
owner: context.repo.owner,
repo: context.repo.repo,
body: intoMarkdown(lines),
body: intoMarkdown(lines),
})
7 changes: 3 additions & 4 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,10 @@ jobs:
test:
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v2
- name: Use Node.js 16
uses: actions/setup-node@v1
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16.15.1
node-version-file: '.nvmrc'
- uses: actions/cache@v2
with:
path: ~/.npm
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16.15.1
18